Closed
Bug 1109431
Opened 9 years ago
Closed 9 years ago
TimestampsFuzzyEqual should be applied to the buffered ranges returned from multiple decoders
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
6.61 KB,
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1024858 Comment 2 suggests that youtube will stop appending audio if it detects that the video track doesn't contain data to cover the same time areas. When we have multiple decoders we can end up with small gaps in the buffered ranges, and youtube is detecting this as a reason to stop appending audio. I can fairly reliably reproduce this by loading the video in the URL and then switching resolution immediately (to force multiple decoders). I haven't been able to reproduce it at all with the patch.
Attachment #8534132 -
Flags: review?(ajones)
Updated•9 years ago
|
Attachment #8534132 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 1•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b71e08f9d34
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/e96e649cb487 for mochitest-2 bustage: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4520195&repo=mozilla-inbound
Flags: needinfo?(matt.woodrow)
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/beec11f1ceed
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(matt.woodrow)
https://hg.mozilla.org/mozilla-central/rev/beec11f1ceed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 5•9 years ago
|
||
Comment on attachment 8534132 [details] [diff] [review] Round the buffered ranges Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve Flash video. [Describe test coverage new/current, TBPL]: m-c. [Risks and why]: Moderate since this affects the behaviour of the TimeRanges object available on all media elements. However, any changes will be small. [String/UUID change made/needed]: None.
Attachment #8534132 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8534132 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•