Closed Bug 1109431 Opened 9 years ago Closed 9 years ago

TimestampsFuzzyEqual should be applied to the buffered ranges returned from multiple decoders

Categories

(Core :: Audio/Video, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Bug 1024858 Comment 2 suggests that youtube will stop appending audio if it detects that the video track doesn't contain data to cover the same time areas.

When we have multiple decoders we can end up with small gaps in the buffered ranges, and youtube is detecting this as a reason to stop appending audio.

I can fairly reliably reproduce this by loading the video in the URL and then switching resolution immediately (to force multiple decoders).

I haven't been able to reproduce it at all with the patch.
Attachment #8534132 - Flags: review?(ajones)
Attachment #8534132 - Flags: review?(ajones) → review+
Flags: needinfo?(matt.woodrow)
https://hg.mozilla.org/mozilla-central/rev/beec11f1ceed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8534132 [details] [diff] [review]
Round the buffered ranges

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: m-c.
[Risks and why]: Moderate since this affects the behaviour of the TimeRanges object available on all media elements. However, any changes will be small.
[String/UUID change made/needed]: None.
Attachment #8534132 - Flags: approval-mozilla-aurora?
Attachment #8534132 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.