1109448 - Remove redundant event listeners and function calls in `initNavbarButtons` for mobile navigation bar

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

This function

    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L25-L38

is called once on page load

    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L70

and every time the window is resized

    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L268

Related, the click event listeners are getting re-initialised every time the window is resized. Similarly, the listeners are getting called multiple times per click (exponentially) because the selector for the event listeners should be for the icons themselves (`.act-tray-mobile .icon` and `.mkt-tray-mobile .icon`), not the parent elements:

    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L41
    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L53

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Related: a `setTimeout` is being used, but a `transitionend` event listener should be used instead here:

    https://github.com/mozilla/fireplace/blob/9c666dec/src/media/js/navbar.js#L30-L37

Comment 2

[Christopher Van Wiemeersch [:cvan]]

PR: https://github.com/mozilla/fireplace/pull/845

Comment 3

[Kevin Ngo [:ngoke]]

Will be fixed with the new Nav.

Steps to See the Fix:

1. Go to Debug page.
2. Click Enable new mkt-nav

Comment 4

[Victor Carciu]

Can you please add some STRs to be executed in the new mkt-nav for this bug or mark this as qa-?