Closed Bug 1109534 Opened 7 years ago Closed 3 years ago

RIL: Decode SMS address as "Called party BCD number"

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED WONTFIX
tracking-b2g backlog

People

(Reporter: edgar, Unassigned)

Details

Now ril_worker decodes SMS address as "extended BCD". But according to the spec [1], we should decode SMS address as "called BCD number" [2] as below:

0x0 -> "0"
0x1 -> "1"
.
.
0x8 -> "8"
0x9 -> "9"
0xa -> "*"
0xb -> "#"
0xc -> "a"
0xd -> "b"
0xe -> "c"
0xf -> used as an endmark in the case of an odd number of number digits

[1] TS 123.040, 9.1.2.3 Semi-octet representation
[2] TS 124.008, 10.5.4.7 Called party BCD number
The same problem is found for decoding SMSC address [1][2]:
"
The contents of octets 3, 4, etc. are the same as those defined for the Called Party BCD Number IE defined in 3GPP TS 24.008.
"

[1] TS 23.040, 8.2.5.2 Destination address element.
[2] http://hg.mozilla.org/mozilla-central/file/d7c76fe69e9a/dom/system/gonk/ril_worker.js#l7988
Assignee: nobody → sawang
[Tracking Requested - why for this release]:
No longer work on this.
Assignee: sawang → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.