Show People whom you shared a Rooom in the Room details

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: oteo, Assigned: paco)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

61 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Once I (as Room owner) share a Room with a contact, that contact name will appear in the "People whom you shared" section in the Room detail
(Reporter)

Updated

4 years ago
Blocks: 1097745
Depends on: 1109558
Depends on: 1109560
(Reporter)

Comment 1

4 years ago
Check the visual for the Room details in box (Hello_RoomDetail.png) https://app.box.com/s/jt5v3rnvv3vqtyoj1n52/1/2717236524/23369558924/1,
(Reporter)

Comment 2

4 years ago
After landing dependent bug 1109558 and bug 1109560, it's only pending to address including the list of contacts whom we shared the Room under Invitees panel.

In this bug we also fix this issue:
1.)Create a Room or open a Room that has not been shared with other contact (Invitees panel is shaded/grey and is not click able)
2.)In Room details tap on "Pick contact" and select a contact to share the room with him
3.)After the SMS or e-mail is sent, we go back to the Room details

Expected behavior: Invitees panel is click able and tapping on it you can see the contact you shared the URL 
Actual behavior: Invitees panel is NOT click able and tapping on it you can NOT see the contact you shared the URL. 

Note: After going back to the list of Rooms and entering in the Room details again I can see the expected behavior.
(Assignee)

Updated

4 years ago
Assignee: nobody → pacorampas
(Assignee)

Comment 3

4 years ago
Created attachment 8538438 [details] [review]
patch in github
(Assignee)

Updated

4 years ago
Attachment #8538438 - Flags: review?(borja.bugzilla)
Comment on attachment 8538438 [details] [review]
patch in github

Great job Paco!!!!! Let's merge this asap! :) Gracias!
Attachment #8538438 - Flags: review?(borja.bugzilla) → review+
(Assignee)

Comment 5

4 years ago
Great :)
Thanks Borja

merged: a9cea50f3b2beedcdb76bf506ec2b2505b1993bb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.