1109630 - Improve and Refactor grunt system

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Daniel Coloma:dcoloma]

* Clean up a bit the grunt tasks to make it more maintainable. 
* Add some features and fixes to help app debugging

In particular:

- stop and start the app before and after build process
- Change git grunt library to be able to get the branch name
- Add branch name to Loop version in settings
- Added version.js to the repo so that zip files can be installed directly
- Remove test task from release task
- Move some grunt tasks to a task folder
- Add gitignore as needed
- Change app name if a server different to the production one is used

Comment 1

[Daniel Coloma:dcoloma]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/382

Comment 2

[Antonio Manuel Amaya Calvo (:amac)]

Comment on attachment 8534350 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/382

I left a pair of comments. I would like to see a new version without the replaces (should be pretty straightforward, hopefully) and I'm not so sure about removing version.js from the .gitignore. Maybe we can just checkin a dummy one so we can just do a zip without grunt but leave it in gitignore?

Comment 3

[Daniel Coloma:dcoloma]

Comment on attachment 8534350 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/382

Please have a look at the new version

Comment 4

[Antonio Manuel Amaya Calvo (:amac)]

Comment on attachment 8534350 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/firefoxos-loop-client/pull/382

Left a couple of comments in git. Fix them and feel free to land. Thank you!

Comment 5

[Antonio Manuel Amaya Calvo (:amac)]

Oh, and as a caveat, please note that when this lands, node_modules must be erased and npm install rerun!

Comment 6

[Daniel Coloma:dcoloma]

Thanks!

Merged in master branch: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/680208cd2adf57c771601115466cd378f716e4fb