1109712 - [Enhancement] Include the Room URL in the Room details

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, enhancement)

Description

[Maria Angeles Oteo (:oteo)]

Be aware that this is an enhancement and it has not been requested by Product team so address this change if you don't have higher priorities.

Comment 1

[Maria Angeles Oteo (:oteo)]

Pau, let's know when you have the corresponding screen updated in box, thanks a lot!

Comment 2

[Maria Angeles Oteo (:oteo)]

Just fyi Romain has confirmed that Room URL length is always 11 characters.

Comment 3

[Pau Masiá [:Pau]]

Screen uploaded in box! Thanks :)

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Screenshot after the patch

Comment 6

[Pau Masiá [:Pau]]

Comment on attachment 8534886 [details]
Screenshot after the patch

The screen doesn't look like the one uploaded in box. Please check it there and if you need further details tell me and I'll make the spec. Thanks.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Screenshot after the patch (V2)

Comment 8

[Borja Salguero [:borjasalguero]]

Comment on attachment 8534880 [details] [review]
Proposed patch

We are almost ready to fix this! But first we need to ensure that the URL has no overflow, adding an ellipsis through CSS. Please fix this and ask me to review again! Thanks!

Comment 9

[Borja Salguero [:borjasalguero]]

Comment on attachment 8534880 [details] [review]
Proposed patch

Please address https://github.com/mozilla-b2g/firefoxos-loop-client/pull/387/files#r21673070 and merge it when ready. Thanks!

Comment 10

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0b0f642099b489c17f90d5a7950eb53e28a01bba