Closed Bug 1109728 Opened 10 years ago Closed 10 years ago

Intermittent browser_devices_get_user_media.js | popup WebRTC indicator visible - Got false, expected true

Categories

(Firefox :: Site Permissions, defect)

Product:
Firefox
Component:
Site Permissions
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox37 --- wontfix
firefox38 --- fixed
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: florian)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Patch v2
2.75 KB, patch
Gijs
: review+
Details | Diff | Splinter Review
08:26:39 INFO - 416 INFO TEST-START | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js 08:26:40 INFO - TEST DEVICES: Using media devices: 08:26:40 INFO - audio: Sine source at 440 Hz 08:26:40 INFO - video: Dummy video device 08:26:41 INFO - 417 INFO checking window state 08:26:41 INFO - 418 INFO Console message: [JavaScript Warning: "Property contained reference to invalid variable. Error in parsing value for 'color'. Falling back to 'inherit'." {file: "chrome://browser/skin/devedition.css" line: 206 column: 7742 source: " var(--url-and-searchbar-color)"}] 08:26:41 INFO - 419 INFO Console message: [JavaScript Warning: "Property contained reference to invalid variable. Error in parsing value for 'color'. Falling back to 'inherit'." {file: "chrome://browser/skin/devedition.css" line: 206 column: 7742 source: " var(--url-and-searchbar-color)"}] 08:26:41 INFO - 420 INFO Console message: [JavaScript Warning: "Property contained reference to invalid variable. Error in parsing value for '-moz-image-region'. Falling back to 'inherit'." {file: "chrome://browser/skin/devedition.css" line: 376 column: 12882 source: " var(--urlbar-dropmarker-region)"}] 08:26:41 INFO - 421 INFO Console message: [JavaScript Warning: "Property contained reference to invalid variable. Error in parsing value for 'list-style-image'. Falling back to 'inherit'." {file: "chrome://browser/skin/devedition.css" line: 375 column: 12832 source: " var(--urlbar-dropmarker-url)"}] 08:26:41 INFO - 422 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | should start the test without any prior popup notification 08:26:41 INFO - 423 INFO getUserMedia audio+video 08:26:41 INFO - 424 INFO requesting devices 08:26:41 INFO - 425 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | webRTC-shareDevices notification shown 08:26:41 INFO - 426 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | notification panel open 08:26:41 INFO - 427 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | notification panel populated 08:26:41 INFO - 428 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | expected notification getUserMedia:request 08:26:41 INFO - 429 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | anchored to device icon 08:26:41 INFO - 430 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | microphone selector visible 08:26:41 INFO - 431 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | camera selector visible 08:26:41 INFO - 432 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | panel using devices icon 08:26:41 INFO - 433 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | received ok 08:26:41 INFO - 434 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | expected notification getUserMedia:response:allow 08:26:41 INFO - 435 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | expected notification recording-device-events 08:26:41 INFO - 436 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | expected camera and microphone to be shared 08:26:41 INFO - 437 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | webRTC-sharingDevices notification appeared 08:26:41 INFO - 438 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | WebRTC indicator visible 08:26:41 INFO - 439 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | camera global indicator as expected 08:26:41 INFO - 440 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | microphone global indicator as expected 08:26:41 INFO - 441 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | screen global indicator as expected 08:26:41 INFO - 442 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | WebRTC menu should be visible 08:26:41 INFO - 443 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | popup WebRTC indicator visible - Got false, expected true 08:26:41 INFO - Stack trace: 08:26:41 INFO - chrome://mochikit/content/browser-test.js:test_is:834 08:26:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/head.js:assertWebRTCIndicatorStatus:683 08:26:41 INFO - self-hosted:next:943 08:26:41 INFO - self-hosted:LegacyIteratorNext:2522 08:26:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js:checkSharingUI:214 08:26:41 INFO - self-hosted:InterpretGeneratorResume:985 08:26:41 INFO - self-hosted:next:911 08:26:41 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23 08:26:41 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7 08:26:41 INFO - this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37 08:26:59 INFO - TEST DEVICES: Using media devices: 08:26:59 INFO - audio: Sine source at 440 Hz 08:26:59 INFO - video: Dummy video device 08:26:59 INFO - 444 INFO TEST-OK | chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js | took 19994ms
Flags: needinfo?(gijskruitbosch+bugs)
There are 6 instances of this in the other bug (out of 250+ stars), all on Linux, both 64 and 32 bit, pgo/opt/asan - but no debug. So not super common, happens roughly once every 3 days or so. Looks like more race conditions... I'm working on some more frequent intermittents right now; if this comes back more heavily, please do re-ping.
Flags: needinfo?(gijskruitbosch+bugs)
Component: General → Device Permissions
See Also: → 1124004
Mark, can you maybe help find an owner for this long-standing orange. I'm considering disabling the test otherwise.
Flags: needinfo?(standard8)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #134) > Mark, can you maybe help find an owner for this long-standing orange. I'm > considering disabling the test otherwise. Forwarding to Gavin, I don't really have time to look at this for the next week or two.
Flags: needinfo?(standard8) → needinfo?(gavin.sharp)
Flags: needinfo?(gavin.sharp) → needinfo?(florian)
Attached patch Patch (obsolete) — — Splinter Review
The test assumes that the global indicator window opens synchronously, I don't think that's a correct assumption, so let's wait for the window to exist and see if that helps with the intermittent failure. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ec31c3fdac6
Flags: needinfo?(florian)
Attachment #8591618 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8591618 [details] [diff] [review] Patch Review of attachment 8591618 [details] [diff] [review]: ----------------------------------------------------------------- I think introducing new setTimeout usages is frowned upon these days. Can you revise without that? ::: browser/base/content/test/general/head.js @@ +639,5 @@ > + * @resolves to the window > + * @rejects if a window with a matching url wasn't found within a meaningful interval > + */ > +function promiseWindow(url) { > + let deferred = Promise.defer(); Please just use new Promise().
Attachment #8591618 - Flags: review?(gijskruitbosch+bugs) → feedback+
Attached patch Patch v2 — — Splinter Review
Attachment #8591618 - Attachment is obsolete: true
Attachment #8591655 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8591655 [details] [diff] [review] Patch v2 Review of attachment 8591655 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/head.js @@ +643,5 @@ > + return new Promise(resolve => { > + Services.obs.addObserver(function obs(win) { > + win.QueryInterface(Ci.nsIDOMWindow); > + if (win.location.href !== url) > + return; Maybe add another info() here before the return, with the href that we're ignoring?
Attachment #8591655 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/65e90f339d63 (In reply to :Gijs Kruitbosch from comment #145) > Maybe add another info() here before the return, with the href that we're > ignoring? Good idea! And thanks for the review! :-)
Depends on: 1154019
https://hg.mozilla.org/mozilla-central/rev/65e90f339d63
Assignee: nobody → florian
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Hi Florian, can you provide a point value.
Iteration: --- → 40.1 - 13 Apr
Flags: qe-verify?
Flags: needinfo?(florian)
Flags: firefox-backlog+
Points: --- → 3
Flags: qe-verify?
Flags: qe-verify-
Flags: needinfo?(florian)
I'm afraid we haven't actually fixed anything here (ie. uplifting this patch wouldn't help), just changed the error message (see bug 1154019 for the new failures).
I wasn't planning to uplift until that's fixed anyway.
Between this and bug 1126107, the frequency has improved, so I'm going to go ahead and uplift recognizing that there are still issues that need to be addressed. https://hg.mozilla.org/releases/mozilla-aurora/rev/d05bd1334e25
status-firefox39: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: