1109754 - [Messages] Consider using a queue to render threads at startup

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Currently, in [1], we append a thread right away in the DOM, and only then we call cursor.continue to get the next thread.

I'd like to investigate whether pushing the threads in an array instead, and rendering them asynchronously using promises or setTimeout (possibly batching several threads in one go), could make the rendering faster.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/thread_list_ui.js#L599

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] julienw:1109754-queuing-threads to mozilla-b2g:master

Comment 2

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Here is a WIP, but I don't see any improvement on Buri.

I tried using a timeout of 0, or 200. 200 had about the same behavior than the current value of 100, 0 was closer to what happens on current master, but I saw no obvious improvements.

Maybe testing on Flame (which is Dual Core) can show a different result though.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

We should consider making it a feature blocker if this improves launch time.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

I'm marking feature-b2g:2.2+, as it's blocking performance meta bug.
If it turns out the approach doesn't improve, then just close the bug or remove flag.

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Julien,
Are we still counting on this approach to improve launch time?
If there's no significant gain, maybe we should remove the feature-b2g flag.
Thought?

Comment 6

[Julien Wajsberg [:julienw] (PTO -> may 13)]

As I said earlier we'd need to test on another phone before saying it's not useful.

But currently we're investing our time on other parts because we think they will bring more important improvements.

Let's keep the flag here for now, we'll revisit when we're done with the other parts.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[changing flag for the performance improvement task]

Comment 8

[Oleg Zasypkin [:azasypkin]]

Tried this patch today on Flame, see video with side by side compassion at [1] (both flames has the latest engineering central pvt build).

For my case, it looks even worse with the queueing patch applied.

[1] https://www.youtube.com/watch?v=SyfTE1dNzzE

Comment 9

[Julien Wajsberg [:julienw] (PTO -> may 13)]

Ok, let's close this then :)