Closed Bug 1109754 Opened 5 years ago Closed 5 years ago
[Messages] Consider using a queue to render threads at startup
46 bytes, text/x-github-pull-request
|Details | Review|
Currently, in , we append a thread right away in the DOM, and only then we call cursor.continue to get the next thread. I'd like to investigate whether pushing the threads in an array instead, and rendering them asynchronously using promises or setTimeout (possibly batching several threads in one go), could make the rendering faster.  https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/thread_list_ui.js#L599
Here is a WIP, but I don't see any improvement on Buri. I tried using a timeout of 0, or 200. 200 had about the same behavior than the current value of 100, 0 was closer to what happens on current master, but I saw no obvious improvements. Maybe testing on Flame (which is Dual Core) can show a different result though.
We should consider making it a feature blocker if this improves launch time.
feature-b2g: --- → 2.2?
I'm marking feature-b2g:2.2+, as it's blocking performance meta bug. If it turns out the approach doesn't improve, then just close the bug or remove flag.
feature-b2g: 2.2? → 2.2+
Hi Julien, Are we still counting on this approach to improve launch time? If there's no significant gain, maybe we should remove the feature-b2g flag. Thought?
As I said earlier we'd need to test on another phone before saying it's not useful. But currently we're investing our time on other parts because we think they will bring more important improvements. Let's keep the flag here for now, we'll revisit when we're done with the other parts.
[changing flag for the performance improvement task]
blocking-b2g: --- → 2.2+
feature-b2g: 2.2+ → ---
Tried this patch today on Flame, see video with side by side compassion at  (both flames has the latest engineering central pvt build). For my case, it looks even worse with the queueing patch applied.  https://www.youtube.com/watch?v=SyfTE1dNzzE
Ok, let's close this then :)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.