1109801 - [Messages] 2 "recipientChanged" events are generated when we add a recipient using the suggestion list

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
0. have at least one contact
1. open new message panel
2. enter the first letter of content, then enter

=> in [1] we call both add and remove; as a result "recipientsChanged" [2] is called twice in a row, which is avoidable work.

[1] https://github.com/mozilla-b2g/gaia/blob/e04ab7651b1e0c67516e1cef7aa4bc6072529885/apps/sms/js/thread_ui.js#L2523-L2529
[2] https://github.com/mozilla-b2g/gaia/blob/e04ab7651b1e0c67516e1cef7aa4bc6072529885/apps/sms/js/thread_ui.js#L319

Comment 1

[Oleg Zasypkin [:azasypkin]]

I see that on the latest master it's called 4 times if recipient is assimilated by Enter key or 2 times if is assimilated by tapping on contact suggestion, ugh.

Comment 2

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 3

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(