1109867 - Error: could not find debugger None

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Josh Matthews [:jdm]]

This looks like it should be simple to fix. When I run any test using `./mach mochitest path/to/test.html` I see "Error: could not find debugger None" show up in the output. This looks like mozdebug.py is at fault: http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdebug/mozdebug/mozdebug.py#105

Comment 1

[Ankit Goyal]

I would like to work on it.

Comment 2

[Josh Matthews [:jdm]]

Go ahead! Let me know if anything is unclear!

Comment 3

[Ankit Goyal]

I am not getting any error. My test ran fine.

Comment 4

[Ankit Goyal]

Are you using the latest Nighty build?

Comment 5

[Josh Matthews [:jdm]]

Yes, I just pulled the last from mozilla-central yesterday when I filed this.

>godot2:mozilla-central jdm$ ./mach mochitest dom/tests/mochitest/bugs/test_DOMWindowCreated_chromeonly.html
>From _tests: Kept 33877 existing; Added/updated 0; Removed 0 files and 0 directories.
>SUITE-START | Running 1 tests
>Error: Could not find debugger None.
>pk12util: PKCS12 IMPORT SUCCESSFUL
>MochitestServer : launching [u'/Users/jdm/src/mozilla-central/obj-x86_64-apple-darwin13.4.0/dist/bin/xpcshell', '-g', u'/Users/jdm/src/mozilla-central/obj-x86_64-apple-darwin13.4.0/dist/NightlyDebug.app/Contents/Resources', '-v', '170', '-f', u'/Users/jdm/src/mozilla-central/obj-x86_64-apple-darwin13.4.0/dist/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/var/folders/m7/9_hs2jb12kl4h0ww513v96cw0000gn/T/tmpGJtaHn.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = true;", '-f', '/Users/jdm/src/mozilla-central/obj-x86_64-apple-darwin13.4.0/_tests/testing/mochitest/server.js']
>runtests.py | Server pid: 692
>runtests.py | Websocket server pid: 693
>runtests.py | SSL tunnel pid: 694
>[692] WARNING: Re-registering a CID?: file /Users/jdm/src/mozilla-central/xpcom/components/nsComponentManager.cpp, line 531
>JavaScript warning: /Users/jdm/src/mozilla-central/obj-x86_64-apple-darwin13.4.0/_tests/testing/mochitest/server.js, line 14: JavaScript 1.7's let blocks are deprecated
>runtests.py | Running tests: start.

Comment 6

[Josh Matthews [:jdm]]

It's not an actual error that prevents anything, but it's confusing.

Comment 7

[Ankit Goyal]

Okay, I am able to reproduce the error. Working on it.

Comment 8

[Ankit Goyal]

Try this:
./mach mochitest --debugger=gdb dom/tests/mochitest/bugs/test_DOMWindowCreated_chromeonly.html

`debugger` is being sent as a python keyword argument by shell script. If you want, I can create a patch by setting default `debugger` value from `None` to `gdb`.

Comment 9

[Josh Matthews [:jdm]]

No, that's not the right solution here. It looks like some (but not all) of the callers of get_debugger_info check for debugger being None; let's make all of them do it.

Comment 10

[Ankit Goyal]

Okay, there are 11 callers.
http://mxr.mozilla.org/mozilla-central/search?string=get_debugger_info%28&case=1&find=&findi=&filter=&hitlimit=&tree=mozilla-central

We can put a check in these functions before calling get_debugger_info()

Comment 11

[Ankit Goyal]

Attachment: Put checks at relevant callers

Now tests are okay

Comment 12

[Josh Matthews [:jdm]]

Great! Could you follow the steps at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed and ask :gps for a review?

Comment 13

[Gregory Szorc [:gps]]

Comment on attachment 8535641 [details] [diff] [review]
Put checks at relevant callers

Review of attachment 8535641 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. I'll land this momentarily. Thanks for the fix!

Comment 14

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/f23bac4bf806

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f23bac4bf806