1110050 - [B2G][SMS] Support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to inform SMS Device Storage to modem.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

In bug 945089, we support to send SMS ACK with PDU_FCS_MEMORY_CAPACITY_EXCEEDED if device is not able to save incoming SMS due to full device storage to indicate the SMSC not to deliver the SMS until device notify the SMSC that the storage is available again [1].

However, we haven't support to proactively inform the device storage to the network  when device storage is changed.

This introduces a potential issue of being unable to receiving further SMS from SMSC until the device informs SMSC that the device storage is available again.

File this bug to support updating the status of device storage to the network.

[1] TS 23.040, Table 1: Error indications related to mobile terminated short message transfer which may be transferred to the originating SC.
[2] TS 23.040, Figure 20c: The alert procedure when the MS notifies the network that it has memory available to receive one or more short messages and MCEF is set.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

The basic idea to support this is to create a monitor to observe the notification from |disk-space-watcher| to notify the storage status via RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to the modem.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1: Support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to inform SMS Device Storage to modem. r=echen

This patch is to 
1. observe the topic of |disk-space-watcher| in SmsService and 
2. report the availability of device storage according to the value from |disk-space-watcher| to the modem via |RIL_REQUEST_REPORT_SMS_MEMORY_STATUS|.

Hi Edgar,

May I have your review for this change?

Thanks!

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v2: Support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to inform SMS Device Storage to modem. r=echen

UICC is removable among devices.
It could be full in the device the UICC previously inserted into, but is available in current test device.
Hence, we have to ensure the first run will always be triggered even when the device storage is available.

Update the patch to address this.

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8536994 [details] [diff] [review]
Patch v2: Support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to inform SMS Device Storage to modem. r=echen

Review of attachment 8536994 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thank you. :)

::: dom/mobilemessage/gonk/SmsService.js
@@ +1065,5 @@
>          }
>          break;
> +      case kDiskSpaceWatcherObserverTopic:
> +        if (DEBUG) {
> +          debug("Observe kDiskSpaceWatcherObserverTopic: " + aData);

nit: I prefer showing original topic string for debugging message,

debug("Observe " + kDiskSpaceWatcherObserverTopic + ": " + aData);

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch: Support RIL_REQUEST_REPORT_SMS_MEMORY_STATUS to inform SMS Device Storage to modem. r=echen

address comment 4.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=cb4c0e7a536d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8c6cee1ee8c9

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c6cee1ee8c9