1110091 - mozSettings logging sometimes fails because of missing Services

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

SettingsRequestManager debugging sometimes fails because of "ReferenceError: Services is not defined".

This makes sense, since we are including Services.jsm after ... I cannot explain why it was working when I tested it.

Comment 1

[:gerard-majax]

Attachment: Fix mozSettings logging use of Services r=qdot

Comment 2

[:gerard-majax]

Attachment: Fix mozSettings logging use of Services r=qdot

Comment 3

[:gerard-majax]

Comment on attachment 8534930 [details] [diff] [review]
Fix mozSettings logging use of Services r=qdot

Sorry for this mistake :(.

Comment 4

[:gerard-majax]

Comment on attachment 8534930 [details] [diff] [review]
Fix mozSettings logging use of Services r=qdot

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 1110091
User impact if declined: unable to get more debug from mozSettings
Testing completed: tested on device
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none.

Comment 5

[:gerard-majax]

Try: https://tbpl.mozilla.org/?tree=Try&rev=1968eb4a4f46

Comment 6

[:gerard-majax]

The same patch applies cleanly on v2.1.
Try: https://tbpl.mozilla.org/?tree=Try&rev=895ccdb3b5aa

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/66535a80b791

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66535a80b791

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/1fc4cba94329