1110142 - E-mail application accepts invalid URLs in Share URL activity

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Maria Angeles Oteo (:oteo)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1109686#c8.

In Loop application, when we use the option "other" to share a URL, we invoke the "Share URL" activity, which should only accept 1 attribute: the URL. 

The fact is that E-mail is currently accepting in the "Share URL" activity Strings that are not valid URLs (e.g. a text + a URL) and we believe it shouldn't.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Can you elaborate on what is being passed to email as the activity payload and what email is doing with the text?  I looked at the referenced bug and it's not clear to me what's going on.  Are we corrupting the URL when including a text payload, or is the idea that we should be ignoring a text payload?

A wrinkle is that the "share" activity is not really well defined right now.  https://developer.mozilla.org/en-US/docs/Web/API/Web_Activities documents the bare minimum, and https://etherpad.mozilla.org/gaia-activities-audit never really finished.  I am under the impression that there is an attempt to standardize a cross-browser sharing API/mechanism, but in the absence of a (new) standard, it doesn't seem like we should change the behaviour of "share" unless we corrupt things (in which case there is no existing usable use-case to avoid breaking).

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Andrew Sutherland [:asuth] from comment #1)
> Can you elaborate on what is being passed to email as the activity payload
> and what email is doing with the text?  I looked at the referenced bug and
> it's not clear to me what's going on.  Are we corrupting the URL when
> including a text payload, or is the idea that we should be ignoring a text
> payload?
> 

No, nothing is corrupted, e-mail app just includes in the body of the message the full string that was passed in the activity. 

> A wrinkle is that the "share" activity is not really well defined right now.
> https://developer.mozilla.org/en-US/docs/Web/API/Web_Activities documents
> the bare minimum, and https://etherpad.mozilla.org/gaia-activities-audit
> never really finished.  I am under the impression that there is an attempt
> to standardize a cross-browser sharing API/mechanism, but in the absence of
> a (new) standard, it doesn't seem like we should change the behaviour of
> "share" unless we corrupt things (in which case there is no existing usable
> use-case to avoid breaking).

OK, just wanted to highlight the current behaviour in case this could be a potential issue for e-mail or apps using the share activity. If you believe the best thing we can do is keeping current behaviour please close this as invalid.

Comment 3

[BMO Automation]

Firefox OS is not being worked on