1110229 - Regression: vertical bars painted in tiles on screen when scrolling

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

Currently on Nightly (12/11), Aurora (12/11), Beta (mozilla-beta 35), when scrolling through content rapidly one will see vertical bars painted on-screen (likely depending on content).

See video: http://youtu.be/wwfoMz_0pvY

Using the e.g, URL to demonstrate this behaviour 

  http://ihackernews.com/comments/8730903
  
mozilla-inbound pushlog

  https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=97068dca449e&tochange=81eafec98b48

[e-mail]
Wed Oct 08 00:13:22 2014 +0000	81eafec98b48	Matt Woodrow — Bug 1077842 - Simplify invalid regions for tiled painted layers to avoid complex region operations. r=jrmuizel

43c963b56723	Matt Woodrow — Bug 1078109 - Make sure we initialize tiled textures to the format we're going to upload with. r=jgilbert

--
Nightly (12/11)
LG Nexus 5 (Android 5.0)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this Android L only, do we know?

Comment 2

[Aaron Train [:aaronmt]]

(In reply to Milan Sreckovic [:milan] from comment #1)
> Is this Android L only, do we know?

No. I can reproduce this on Android 4.x as well (e.g, my HTC One, S4/S5)

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

This sounds like bug 1073554.

Comment 4

[Aaron Train [:aaronmt]]

I don't think we can ship Firefox 35 with this bug, it's embarrassing.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Jeff, do you have a device where this reproduces?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

I tried a build with matt's patches mentioned in comemnt #0 backed out. Before the backout I saw both horizontal and vertical dark lines when scrolling quickly. With the backout I only see the horizontal ones.

Comment 8

[Benoit Girard (:BenWa)]

Attachment: patch

This patch fixes the problem for me. A small tweak to how we do progressive painting. I don't feel very excited to put this on beta however without specific QA resources for this.

Comment 9

[Benoit Girard (:BenWa)]

Comment on attachment 8545412 [details] [diff] [review]
patch

Review of attachment 8545412 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/client/TiledContentClient.cpp
@@ +1508,5 @@
>      if (!aRegionToPaint.IsEmpty()) {
> +      if (mResolution != CSSToParentLayerScale(1)) {
> +        // Paint the entire tile for low-res. This is aimed to fixing low-res resampling
> +        // and to avoid doing costly region accurate painting for a small area.
> +        aRegionToPaint = tileBounds;

We might want to insert with the visible region instead of the thebes callback doesn't allow us to specific a region larger than the layer.

Comment 10

[Benoit Girard (:BenWa)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dabe5d1b739d

Comment 11

[Benoit Girard (:BenWa)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d8240287c71a

Comment 12

[Robert Kaiser]

[Tracking Requested - why for this release]:

(In reply to Aaron Train [:aaronmt] from comment #4)
> I don't think we can ship Firefox 35 with this bug, it's embarrassing.

Given that, it should be tracking.

Comment 13

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/142bb8c88b3b

Comment 14

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6698118c0b54

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2dbc61faf188
https://hg.mozilla.org/releases/mozilla-beta/rev/137baee3dda4

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8545412 [details] [diff] [review]
patch

We need this in asap because of bug 1073554 so we're going ahead with uplift based on QE manual testing and also that we're going to do a b11 build to ship by EOD tomorrow so we can collect more data.

Comment 17

[Benoit Girard (:BenWa)]

Thanks for the help here. It's appreciated.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/142bb8c88b3b
https://hg.mozilla.org/mozilla-central/rev/6698118c0b54

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/137baee3dda4

Comment 20

[Flaviu Cos]

Verified as fixed in Firefox 35 beta 11;
Device: Samsung Galaxy S4 (Android 4.4.2).

Comment 21

[Flaviu Cos]

Verified as fixed builds:
- 37.0a1 2015-01-09;
- 36.0a2 2015-01-09;

Device: Samsung Galaxy S4 (Android 4.4.2).