Closed
Bug 1110229
Opened 9 years ago
Closed 9 years ago
Regression: vertical bars painted in tiles on screen when scrolling
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(firefox34 unaffected, firefox35+ verified, firefox36+ verified, firefox37+ verified, fennec35+)
VERIFIED
FIXED
Firefox 37
People
(Reporter: aaronmt, Assigned: BenWa)
References
()
Details
(Keywords: regression, reproducible, testcase)
Attachments
(1 file)
1.13 KB,
patch
|
nical
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
Currently on Nightly (12/11), Aurora (12/11), Beta (mozilla-beta 35), when scrolling through content rapidly one will see vertical bars painted on-screen (likely depending on content). See video: http://youtu.be/wwfoMz_0pvY Using the e.g, URL to demonstrate this behaviour http://ihackernews.com/comments/8730903 mozilla-inbound pushlog https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=97068dca449e&tochange=81eafec98b48 mwoodrow@mozilla.com Wed Oct 08 00:13:22 2014 +0000 81eafec98b48 Matt Woodrow — Bug 1077842 - Simplify invalid regions for tiled painted layers to avoid complex region operations. r=jrmuizel 43c963b56723 Matt Woodrow — Bug 1078109 - Make sure we initialize tiled textures to the format we're going to upload with. r=jgilbert -- Nightly (12/11) LG Nexus 5 (Android 5.0)
Flags: in-testsuite?
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → matt.woodrow
Status: NEW → ASSIGNED
Is this Android L only, do we know?
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #1) > Is this Android L only, do we know? No. I can reproduce this on Android 4.x as well (e.g, my HTC One, S4/S5)
Comment 3•9 years ago
|
||
This sounds like bug 1073554.
tracking-fennec: ? → 35+
Reporter | ||
Comment 4•9 years ago
|
||
I don't think we can ship Firefox 35 with this bug, it's embarrassing.
Jeff, do you have a device where this reproduces?
Flags: needinfo?(jgilbert)
I tried a build with matt's patches mentioned in comemnt #0 backed out. Before the backout I saw both horizontal and vertical dark lines when scrolling quickly. With the backout I only see the horizontal ones.
Assignee | ||
Comment 8•9 years ago
|
||
This patch fixes the problem for me. A small tweak to how we do progressive painting. I don't feel very excited to put this on beta however without specific QA resources for this.
Assignee: matt.woodrow → bgirard
Flags: needinfo?(jgilbert)
Attachment #8545412 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8545412 [details] [diff] [review] patch Review of attachment 8545412 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/TiledContentClient.cpp @@ +1508,5 @@ > if (!aRegionToPaint.IsEmpty()) { > + if (mResolution != CSSToParentLayerScale(1)) { > + // Paint the entire tile for low-res. This is aimed to fixing low-res resampling > + // and to avoid doing costly region accurate painting for a small area. > + aRegionToPaint = tileBounds; We might want to insert with the visible region instead of the thebes callback doesn't allow us to specific a region larger than the layer.
Assignee | ||
Comment 10•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dabe5d1b739d
Assignee | ||
Comment 11•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d8240287c71a
Comment 12•9 years ago
|
||
[Tracking Requested - why for this release]: (In reply to Aaron Train [:aaronmt] from comment #4) > I don't think we can ship Firefox 35 with this bug, it's embarrassing. Given that, it should be tracking.
Updated•9 years ago
|
Attachment #8545412 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/142bb8c88b3b
Assignee | ||
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6698118c0b54
Updated•9 years ago
|
Comment 15•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2dbc61faf188 https://hg.mozilla.org/releases/mozilla-beta/rev/137baee3dda4
Comment 16•9 years ago
|
||
Comment on attachment 8545412 [details] [diff] [review] patch We need this in asap because of bug 1073554 so we're going ahead with uplift based on QE manual testing and also that we're going to do a b11 build to ship by EOD tomorrow so we can collect more data.
Attachment #8545412 -
Flags: approval-mozilla-release+
Attachment #8545412 -
Flags: approval-mozilla-beta+
Attachment #8545412 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8545412 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 17•9 years ago
|
||
Thanks for the help here. It's appreciated.
https://hg.mozilla.org/mozilla-central/rev/142bb8c88b3b https://hg.mozilla.org/mozilla-central/rev/6698118c0b54
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment 20•9 years ago
|
||
Verified as fixed in Firefox 35 beta 11; Device: Samsung Galaxy S4 (Android 4.4.2).
Comment 21•9 years ago
|
||
Verified as fixed builds: - 37.0a1 2015-01-09; - 36.0a2 2015-01-09; Device: Samsung Galaxy S4 (Android 4.4.2).
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•