1110306 - [Facebook]In air-plane mode facebook options are not greyed out

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[[:RJ]]

Attachment: logcat_20141211_1100.txt

Description:
When in phone is in airplane mode with facebook synced contacts imported, facebook options are not greyed out

Repro Steps:
1) Update a Flame to 20141210040201
2) sync facebook contacts to phone 
3) Turn airplane mode on
4) Go to contact and look at facebook option


Actual:
icons are not greyed out, when tapping them leads to browser stating this requires an internet connection


Expected:
Icons are grey and untappable 

Environmental Variables:
Device: Flame 2.2
Build ID: 20141210040201
Gaia: e17c5656dbf517d48fb61ac9bc92119e023fd717
Gecko: be1f49e80d2d
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Repro frequency:100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/5267/
See attached:logcat, video clip: https://www.youtube.com/watch?v=W9ZHaLk4q3s

Comment 1

[Cody Roesch [:croesch]]

Tested with Shallow Flash on 319mb using Engineering builds.

This bug repro's on Flame KK builds: Flame 2.2 KK

Actual Results: Facebook options for contacts remain available when airplane mode is enabled.

Repro Rate: 3/3

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141211040110
Gaia: 1a956437210d2b16988d2ddbf40c9a38d8474435
Gecko: d92db71d4e67
Version: 37.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.1 KK, Flame 2.0 KK, Flame v188-1 Base

Actual Result: Facebook options for contacts are properly greyed out when airplane is enabled.

Repro Rate: 0/6

Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141210190812
Gaia: 97873dca486abf4162a3345e71b375806937bdec
Gecko: 9faa165ac85d
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141211052214
Gaia: 3deab7205f92cfad10f03a444fcdc7fbeee8e6b4
Gecko: b8d376961705
Version: 32.0 (2.0) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame v188-1 Base
BuildID: 20141021162107
Gaia: 8c5c956ee6909408e29f375cc7d843a03d92f3d8
Version: 32.0 (2.0)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Joshua Mitchell (Inactive)]

Nomming for 2.2 : Regression, Fails a test-case, Inconsistent with other areas of the phone that properly grays out unavailable selections.

Comment 3

[Joshua Mitchell (Inactive)]

B2G-Inbound Regression Window:

Last Working:
Device: Flame 2.2
Build ID: 20141118005226
Gaia: 7fb4ddfb74a0481d813bbd554a91c1e009e16412
Gecko: 36b813268df1
Version: 36.0a1 (2.2)
Firmware Version: v188-1

First Broken:
Device: Flame 2.2
Build ID: 20141118020726
Gaia: 4aee256937afe9db2520752650685ba61ce6097d
Gecko: 6e0db2d9eca8
Version: 36.0a1 (2.2)
Firmware Version: v188-1

Gaia/Gecko Swap
Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 7fb4ddfb74a0481d813bbd554a91c1e009e16412
Gecko: 6e0db2d9eca8
First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 4aee256937afe9db2520752650685ba61ce6097d 
Gecko: 36b813268df1

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/7fb4ddfb74a0481d813bbd554a91c1e009e16412...4aee256937afe9db2520752650685ba61ce6097d
------------------------------------------------------------------------------------------------------

Caused by the patch to Bug 837924 - can you take a look Francisco

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

this is the expected behavior, in bug 837924 we changed the behavior of the buttons to be always enabled, and let the browser handle the case of connectivity (since from the browser you can access the connectivity settings).

Closing as works for me.

Comment 5

[Johan Lorenzo [:jlorenzo]]

I update the expected in the Moztrap test case for 2.2: https://moztrap.mozilla.org/manage/cases/?filter-id=5267&filter-productversion=217

Changing the resolution to invalid since we didn't fix anything here, the expected behavior is no more the right one.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Removing the nom based on comment 4 and comment 5