Closed Bug 1110455 Opened 7 years ago Closed 7 years ago

Add --sort-by=block-counts option to dmd.py

Categories

(Core :: DMD, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file)

ehoogeveen suggested this. It only makes sense when used with --sample-below=1, so maybe it should give a warning if you use it without that.
Technically I guess if a small allocation shows up so often that even with the sampling it's one of the top entries, that's more reason to look into it :)

I was thinking that it could use cmpByUsableSize [1] on a tie, though for large block counts a tie might not be very likely.

[1] http://dxr.mozilla.org/mozilla-central/source/memory/replace/dmd/dmd.py?from=dmd.py#134
This required tweaking the "sort-by" tests a little.
Attachment #8536285 - Flags: review?(continuation)
Attachment #8536285 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/314802d1887c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.