Add CENC support to MoofParser

RESOLVED FIXED in Firefox 36

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ajones, Assigned: ajones)

Tracking

(Blocks 1 bug)

Trunk
mozilla37
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(3 attachments)

Switch CENC demuxing of fragmented MP4 over to MoofParser
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Comment on attachment 8535394 [details] [diff] [review]
Add CENC support to MoofParser

Review of attachment 8535394 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/MoofParser.cpp
@@ +251,1 @@
>        if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) {

nit: } else if {

@@ +251,5 @@
>        if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) {
> +        if (box.IsType("tfdt")) {
> +          tfdt = Tfdt(box);
> +        } else if (box.IsType("trun")) {
> +            ParseTrun(box, tfhd, tfdt, aMdhd, aEdts);

nit: inconsistent indent
Attachment #8535394 - Flags: review?(edwin) → review+
https://hg.mozilla.org/mozilla-central/rev/f3c3eafffc60
https://hg.mozilla.org/mozilla-central/rev/54759604f407
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8535394 [details] [diff] [review]
Add CENC support to MoofParser

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; more likely to receive flash video from youtube.
[Describe test coverage new/current, TBPL]: Landed on m-c, unit test.
[Risks and why]: Low, this affects only the MSE feature.
[String/UUID change made/needed]: None.

This request is for all patches in this bug.
Attachment #8535394 - Flags: approval-mozilla-aurora?
Attachment #8535394 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Second patch needs rebasing.
Flags: needinfo?(ajones)
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.