Closed
Bug 1110608
Opened 9 years ago
Closed 9 years ago
Add CENC support to MoofParser
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ajones, Assigned: ajones)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
4.56 KB,
patch
|
eflores
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
212.88 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
311.05 KB,
patch
|
Details | Diff | Splinter Review |
Switch CENC demuxing of fragmented MP4 over to MoofParser
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8535394 -
Flags: review?(edwin)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ajones
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8535395 -
Flags: review?(edwin)
Comment on attachment 8535394 [details] [diff] [review] Add CENC support to MoofParser Review of attachment 8535394 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/libstagefright/binding/MoofParser.cpp @@ +251,1 @@ > if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) { nit: } else if { @@ +251,5 @@ > if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) { > + if (box.IsType("tfdt")) { > + tfdt = Tfdt(box); > + } else if (box.IsType("trun")) { > + ParseTrun(box, tfhd, tfdt, aMdhd, aEdts); nit: inconsistent indent
Attachment #8535394 -
Flags: review?(edwin) → review+
Attachment #8535395 -
Flags: review?(edwin) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf7d7507577 https://hg.mozilla.org/integration/mozilla-inbound/rev/03e5a89726be
Comment 5•9 years ago
|
||
Backed out for non-unified bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/230e9671a456 https://hg.mozilla.org/integration/mozilla-inbound/rev/9bda70b04207
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3c3eafffc60 https://hg.mozilla.org/integration/mozilla-inbound/rev/54759604f407
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3c3eafffc60 https://hg.mozilla.org/mozilla-central/rev/54759604f407
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 8•9 years ago
|
||
Comment on attachment 8535394 [details] [diff] [review] Add CENC support to MoofParser Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing; more likely to receive flash video from youtube. [Describe test coverage new/current, TBPL]: Landed on m-c, unit test. [Risks and why]: Low, this affects only the MSE feature. [String/UUID change made/needed]: None. This request is for all patches in this bug.
Attachment #8535394 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8535394 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
Second patch needs rebasing.
Comment 10•9 years ago
|
||
Flags: needinfo?(ajones)
Updated•9 years ago
|
Keywords: branch-patch-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c4fdc95dd1fc https://hg.mozilla.org/releases/mozilla-aurora/rev/548a7408f76b
You need to log in
before you can comment on or make changes to this bug.
Description
•