1110608 - Add CENC support to MoofParser

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Switch CENC demuxing of fragmented MP4 over to MoofParser

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Add CENC support to MoofParser

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Unit test for MP4 demuxer with CENC

Comment 3

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8535394 [details] [diff] [review]
Add CENC support to MoofParser

Review of attachment 8535394 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/MoofParser.cpp
@@ +251,1 @@
>        if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) {

nit: } else if {

@@ +251,5 @@
>        if (!aTrex.mTrackId || tfhd.mTrackId == aTrex.mTrackId) {
> +        if (box.IsType("tfdt")) {
> +          tfdt = Tfdt(box);
> +        } else if (box.IsType("trun")) {
> +            ParseTrun(box, tfhd, tfdt, aMdhd, aEdts);

nit: inconsistent indent

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf7d7507577
https://hg.mozilla.org/integration/mozilla-inbound/rev/03e5a89726be

Comment 5

[Nigel Babu [:nigelb]]

Backed out for non-unified bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/230e9671a456
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bda70b04207

Comment 6

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3c3eafffc60
https://hg.mozilla.org/integration/mozilla-inbound/rev/54759604f407

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3c3eafffc60
https://hg.mozilla.org/mozilla-central/rev/54759604f407

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8535394 [details] [diff] [review]
Add CENC support to MoofParser

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing; more likely to receive flash video from youtube.
[Describe test coverage new/current, TBPL]: Landed on m-c, unit test.
[Risks and why]: Low, this affects only the MSE feature.
[String/UUID change made/needed]: None.

This request is for all patches in this bug.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Second patch needs rebasing.

Comment 10

[Ralph Giles (:rillian)]

Attachment: Backport unit test patch to Aurora.

Comment 11

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c4fdc95dd1fc
https://hg.mozilla.org/releases/mozilla-aurora/rev/548a7408f76b