Closed Bug 111072 Opened 24 years ago Closed 24 years ago

nsIOService::ExtractUrlPart does not return correct HOST (flag=IOService.url_Host)

Categories

(Core :: Networking, defect, P1)

Product:
Core
Component:
Networking
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: cmanske, Assigned: darin.moz)

References

Details

Attachments

(1 file)

v1.0 patch
1.17 KB, patch
cmanske
: review+
mscott
: superreview+
Details | Diff | Splinter Review
With recent changes to network code for bug 103916, nsIOService::ExtractUrlPart doesn't seem to return the correct host for cases like: "file:///M:/myfile.html" Current code returns the entire path: "///M:/myfile.html" when trying to obtain just the host part.
This was discovered investigating failure in Composer's "MakeRelativeUrl()" JS method -- adding dependency.
Blocks: 110756
i see this too... looks like it happens whenever the url contains an empty authority section.
Attached patch v1.0 patch — — Splinter Review
andreas: can you review this patch? thx!
Comment on attachment 58740 [details] [diff] [review] v1.0 patch Ok, initialize the out param and check the authority length. Also return if there's no path. Seems pretty clear to me even though I'm not a network specialist! r=cmanske
Attachment #58740 - Flags: review+
Oh yea, and I also applied the patch and it fixed the problem in bug 110756.
-> me
Assignee: andreas.otte → darin
Comment on attachment 58740 [details] [diff] [review] v1.0 patch looks good to me too r=andreas.otte@debitel.net
Comment on attachment 58740 [details] [diff] [review] v1.0 patch sr=mscott
Attachment #58740 - Flags: superreview+
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: