1110832 - When clicking on the notification about someone has joined a room, Room list in Loop should be launched

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

If you are the owner/creator of a room, if someone else joins to that room, you will receive a notification about it (already implemented)

According to the WFs if the owner clicks on the notification Loop application will be launched in the Room List screen.

Comment 1

[Maria Angeles Oteo (:oteo)]

Resolving the bug, as it's already implemented

Comment 2

[Maria Angeles Oteo (:oteo)]

Reopening again, as after talking with Jose Antonio, it seems that all is not addressed. He has told that we could be in Loop settings application before clicking on the notification and when we tap on it, settings is shown instead of the list of Rooms.

I'm a little worried about this requirement, in case we have joined a Room1, if we press home button to put Loop application in background, if we receive a notification from Room2 and tap on it, what should it happen? should we leave Room2 and open Room list?

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

If the user has joined a room and she/he taps on a new notification maybe we should leave the current room and present the room list to the user. Take this bug and will explore this solution in the mean time until UX shed some light into the question Maria posted at comment 2.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/415

Comment 5

[Maria Angeles Oteo (:oteo)]

I talked with Mónica about it, her first proposal and preferred solution is:
1)When user is already in a Room (e.g Room 1) and receives a notification that someone has joined to Room 2 and clicks on it, the Room list should be shown and in case the user joins to other room (not Room1) a confirmation prompt should be offered to ensures that he wants to leave Room 1 and join to Room X. 

In case this proposal could be complex or risky to implement, a second one could be:
2)When user clicks on the notification, as he's already in a Room, he should be prompted about if he's sure of leaving room1 and join to Room2.

Let's talk about the feasibility of both proposals tomorrow before asking Mónica about the final flow/strings...

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8538053 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/415

WIP

Option 1 implemented.

We would need the string for the confirmation screen. Current string is:

'leaveRequest = Do you want to leave current room and joint the one you chose?'

Mónica, could you provide it please? Thanks.

Comment 7

[Mónica UX/UI]

Hey.. 

"You are already in a room. Do you want to leave it and join the one you have chosen?"

Comment 8

[Borja Salguero [:borjasalguero]]

Hi Monica,
When we are in 'Room1' and we move to the 'Room List' due to the incoming notification, there is no way of knowing which room was the one you are connected to. Could you check this scenario? Thanks!

Comment 9

[Mónica UX/UI]

Hey Borja,
yeah it's true. 

Then, I think that is better that in this release the user must leave the room when he tap on notification:
2)When user clicks on the notification, as he's already in a Room, he should be prompted about if he's sure of leaving room1 and join to Room2.

While, we think the best UX solution for this case in the future...

Comment 10

[Maria Angeles Oteo (:oteo)]

After talking with Jorge, for this 1.1.1 version we are not in time to achieve his preferred solution that would be allowing to enter directly in the Room when clicking on the notification, of course taking into account the special case that the user could be previously in another Room. 
This has been a last minute requirement too close to the Feature Landing.

In this bug we have been discussing about the implementation of going to the Room list when clicking on the notification as it was specified in the WF. In the case the user is already in another room made Monica to offer a pair of proposals that seem to have issues both of them (comment 5);

Option 1) Issue explained by Borja in comment 8
Option 2) Not coherent with the rest of cases already implemented, as if user is already in a Room and clicks on the notification, after asking to the user to confirm if leaving the Room he's now in, it will be joined to the new Room.

What it's implemented right now, it's that when clicking on the notification we are going back to the Loop application screen where we were before and I think that for this 1.1.1 release it is enough.

Comment 11

[Maria Angeles Oteo (:oteo)]

Closing the bug as Won't fix.

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8538053 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/415

(In reply to Maria Angeles Oteo (:oteo) from comment #11)
> Closing the bug as Won't fix.

Let's reset the review request then. Thanks.