Closed
Bug 1110910
Opened 10 years ago
Closed 7 years ago
strip out $log.debug statements from our minified js files in /dist
Categories
(Tree Management :: Treeherder: Frontend, defect, P4)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: camd, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
grunt-strip may be able to do this. I fear this is affecting our performance somewhat. Those calls don't get put in the console, but any computations of values in the arguments will happen. So we should strip these lines out to be as lean as possible.
https://www.npmjs.com/package/grunt-strip
Comment 1•10 years ago
|
||
I guess an alternative would be to stick the whole thing (including the computation for values in the arguments) inside a debug-only conditional -- if stripping as part of the build proved to be too problematic - or if we found they started interfering with our ability to profile the non-dist build when working locally etc.
Keywords: perf
Updated•10 years ago
|
Priority: -- → P2
Updated•10 years ago
|
Priority: P2 → P3
Updated•10 years ago
|
Priority: P3 → P4
Updated•7 years ago
|
Component: Treeherder → Treeherder: Frontend
Comment 2•7 years ago
|
||
Wontfix given bug 1409103.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•