1111025 - Add newChanelChannelFromURI2(LoadInfo) to nsIIOService

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1111025_add_newChannelFromURI2.patch

Jonas, please note that I haven't updated NS_newChannel(LoadInfo) in nsNetutil.h to call the just added ioservice->NewChannelWithLoadInfo. Reason is, that we would have duplicate code for setting the loadGroup, NotificationCallbacks and such.

I think it's cleaner this way!

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8535869 [details] [diff] [review]
bug_1111025_add_newChannelFromURI2.patch

Just discussed with Jonas on IRC. We should add an internal function in ioservice that is called from NewChannelFromURI2 as well as NewChannelFromURIWithLoadInfo so we can propagate the loadInfo all the way to the protocolhandler.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1111025_add_newChannelFromURI2.patch

Jonas, I added an internal function so we can pass the loadInfo all the way to the ProtocolHandlers whenever we call NewChannelFromURIWithLoadInfo().

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/adc247a722ef

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adc247a722ef