Closed
Bug 1111025
Opened 9 years ago
Closed 9 years ago
Add newChanelChannelFromURI2(LoadInfo) to nsIIOService
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file, 1 obsolete file)
12.39 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Jonas, please note that I haven't updated NS_newChannel(LoadInfo) in nsNetutil.h to call the just added ioservice->NewChannelWithLoadInfo. Reason is, that we would have duplicate code for setting the loadGroup, NotificationCallbacks and such. I think it's cleaner this way!
Attachment #8535869 -
Flags: review?(jonas)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8535869 [details] [diff] [review] bug_1111025_add_newChannelFromURI2.patch Just discussed with Jonas on IRC. We should add an internal function in ioservice that is called from NewChannelFromURI2 as well as NewChannelFromURIWithLoadInfo so we can propagate the loadInfo all the way to the protocolhandler.
Attachment #8535869 -
Flags: review?(jonas)
Assignee | ||
Comment 3•9 years ago
|
||
Jonas, I added an internal function so we can pass the loadInfo all the way to the ProtocolHandlers whenever we call NewChannelFromURIWithLoadInfo().
Attachment #8535869 -
Attachment is obsolete: true
Attachment #8536311 -
Flags: review?(jonas)
Attachment #8536311 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/adc247a722ef
Target Milestone: --- → mozilla37
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/adc247a722ef
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•