1111109 - [Homescreen] "Done" button is inactive in "edit mode", when switching panels with icons in reduced size view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[sarsenyev]

Attachment: stuckediconslogcat

Description:
When reducing icons size view with "^" button, the "Done" button becomes inactive in "Edit" mode when tapping and the panel is blue
   
Repro Steps:
1) Update a Flame device to BuildID: 20141212040206
2) Tap the "^" icon to display all icons in reduced size
3) Long tap any panel to see the icons in reduced size, change panel back and forth, until one panel will stuck with blue color
4) Tap "Done" button
  
Actual:
The "Done" button is inactive in "Edit" mode
  
Expected: 
The "Done" button is active

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141212040206
Gaia: 1d9ae9cca415ad093beba9521c429350e1f2b14d
Gecko: 5288b15d22de
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

  
Repro frequency: 70%
See attached: logcat, YouTube

Comment 1

[sarsenyev]

This feature is not implemented for 2.1 and 2.0

"Flame 2.1

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141215001202
Gaia: 97873dca486abf4162a3345e71b375806937bdec
Gecko: ec87f4f41d3d
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

"Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141212000203
Gaia: f3b9806f687fbbd7eba6b0e1f6ebb8bde09840ea
Gecko: 32f9fae79b89
Gonk: 263b5f41f7733c5577fb101eb4dc8ac5c11cfa8d
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0"

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

NI homescreen owner for a blocking decision based on the severity of this bug.

Comment 3

[Parul Mathur [:pragmatic] - out of office - please ni? [:bajaj] instead]

:kgrandon: would you consider this bug to be a blocker?

Comment 4

[Kevin Grandon :kgrandon]

Looks like it's already in triage.

Comment 5

[Chris Lord [:cwiiis]]

I couldn't reproduce this even after watching the video... If anyone can do so reliably, some very explicit STR would be appreciated.

Comment 6

[Seth Miko [:SMiko]]

I was able to repro on Flame 2.2 (319mb/shallow flash) 
(see video) http://youtu.be/XXeTZlB7Ei4 

Actual result: The row remains highlighted and the "done" button is unresponsive.

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141219040202
Gaia: deb90229734e5397cda806fb11f2e001fba83399
Gecko: 021b09e92d30
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

STR:
1: Collapse all groups and enter edit mode.
2: Long tap on the bottom row and attempt to drag downwards as if you were scrolling down.

Notes: 
1: On several occasions, this issue caused the device to become unresponsive. (see video at 1:05)
After a few minutes, the device crashes back to the homescreen.

Comment 7

[Peter Bylenga [:PBylenga]]

Note, I was also able to reproduce this issue, when I did it, the group wasn't highlighted.   I used the same steps as Comment 6.  Dragged a group towards the bottom of the screen repeatedly until it was unresponsive.

Comment 8

[Gregor Wagner [:gwagner]]

Broken functionality.

Comment 9

[Chris Lord [:cwiiis]]

I'll try to reproduce again.

Comment 10

[Chris Lord [:cwiiis]]

Attachment: Fix (probably)

So I was able to reproduce, and the logcat lead me to finding this error which I think caused it. I can't reproduce after this fix.

However, because I was unable to figure the *exact* method of reproduction, I can't guarantee that this fixes the problem, or write a test for it... But I believe that this is the fix.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8546045 [details] [review]
Fix (probably)

I haven't been able to reproduce this, but the code change seems fine to me.

Comment 12

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/70aa80e460d13a4365401a07af5433462c79bd2c

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest Flame v2.2.
See attachment: verified_v2.2.mp4.
Reproduce rate: 0/8.

STR:
1. Tap the "^" icons on homescreen to collapse all groups.
2. Enter the edit mode.
3. Long tap on the bottom row and attempt to drag downwards as if you were scrolling down (or drag down and drag up).
4. Repeat step 3.
**The panel will not stuck with blue color.
5. Tap Done.
**The "Done" button is actived,and then exit the edit mode.

Flame 2.2 build:
Build ID               20150304002529
Gaia Revision          8b4b3e4b7e7c308764f71542437fd60625ac6b75
Gaia Date              2015-03-03 15:01:17
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2cb52b7cda5a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150304.042036
Firmware Date          Wed Mar  4 04:20:47 EST 2015
Bootloader             L1TC000118D0

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.MP4