1111159 - Inline the IsArrayIterator intrinsic

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In a simple testcase like attachment 8535691 [details] this gives us a 20-25% speedup because instead of doing a CallNative we end up doing ... nothing at all, because TI knows we only have objects with this class coming through here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Inline the IsArrayIterator intrinsic in Ion code to speed up for-of loops

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8535963 [details] [diff] [review]
Inline the IsArrayIterator intrinsic in Ion code to speed up for-of loops

Review of attachment 8535963 [details] [diff] [review]:
-----------------------------------------------------------------

Take it if you want it, I wanted to see if there was anything interesting in this to learn, seeing as I opened up the bug.  (There really wasn't.)

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 8535963 [details] [diff] [review]
Inline the IsArrayIterator intrinsic in Ion code to speed up for-of loops

Review of attachment 8535963 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think I can "fork" a request into two so bz gets review-granted email from me, *and* still has an outstanding request, so flipping the reviews' senses to get at least the former here, at his request.

Comment 4

[Jan de Mooij [:jandem]]

Bleh, I wrote a patch for this and IsStringIterator in bug 932714 but forgot to land them :(

(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #3)
> I don't think I can "fork" a request into two so bz gets review-granted
> email from me, *and* still has an outstanding request, so flipping the
> reviews' senses to get at least the former here, at his request.

The page where you r+, has an "addl. review" field at the bottom so you can r+ there without touching the other requests :)

Comment 6

[Jan de Mooij [:jandem]]

Comment on attachment 8535963 [details] [diff] [review]
Inline the IsArrayIterator intrinsic in Ion code to speed up for-of loops

Review of attachment 8535963 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me too, thanks for doing this.

Maybe you can do the same for IsStringIterator, as it works exactly the same?

Comment 7

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #4)
> (In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #3)
> > I don't think I can "fork" a request into two so bz gets review-granted
> > email from me, *and* still has an outstanding request, so flipping the
> > reviews' senses to get at least the former here, at his request.
> 
> The page where you r+, has an "addl. review" field at the bottom so you can
> r+ there without touching the other requests :)

bz probably doesn't get a review-granted mail in that case. Nevermind me :)

Comment 8

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1910e8b4c026

Comment 9

[Boris Zbarsky [:bzbarsky]]

That's with StringIterator bits too.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1910e8b4c026