1111256 - Invalid Python version string matching on Debian sid

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

The Python interpreter version on my Debian sid system is "2.7.9rc1":

% python --version
Python 2.7.9rc1

This is causing problems with mach's parsing:

ValueError: invalid version number '2.7.9rc1'
 
File "/home/ato/Code/gecko/src/python/mozboot/mozboot/mach_commands.py", line 24, in bootstrap
bootstrapper.bootstrap()
File "/home/ato/Code/gecko/src/python/mozboot/mozboot/bootstrap.py", line 98, in bootstrap
self.instance.ensure_python_modern()
File "/home/ato/Code/gecko/src/python/mozboot/mozboot/base.py", line 276, in ensure_python_modern
modern, version = self.is_python_modern()
File "/home/ato/Code/gecko/src/python/mozboot/mozboot/base.py", line 271, in is_python_modern
our = StrictVersion(match.group(1))
File "/usr/lib/python2.7/distutils/version.py", line 40, in __init__
self.parse(vstring)
File "/usr/lib/python2.7/distutils/version.py", line 107, in parse
raise ValueError, "invalid version number '%s'" % vstring

Comment 1

[Andreas Tolfsen ❲:ato❳]

This happens on calling `./mach bootstrap`.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Full output: https://gist.github.com/andreastt/a073fead0af047b74de1

Comment 3

[Pavel Roskin]

Attachment: loose-python.diff

I guess StrictVersion should be replaced with LooseVersion everywhere, or at least in the files where the Python version is checked. It's ironic that Python itself doesn't adhere to a versioning scheme compatible with StrictVersion, at least for release candidates.

Please test the patch.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8539585 [details] [diff] [review]
loose-python.diff

Review of attachment 8539585 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. I'll commit this for you. Thanks for sending it in!

FTR, next time please set the review? flag in Bugzilla to request review from somebody.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/48786ef504ff

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/48786ef504ff