1111294 - Error message with [JavaScript Application] after simulator download failure

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[seanlinsley]

Attachment: failed.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20141212030201

Steps to reproduce:

When attempting to download a Firefox OS runtime for Web IDE, it understandably failed because of my internet connection at the time.


Actual results:

However, the error message was titled with "[JavaScript Application]". Also, the menu bar's color changed slightly while the JS alert was open.

Comment 1

[seanlinsley]

I'm not sure whether my Firefox version is "37 branch" or trunk, but I'm running Firefox Nightly.

Comment 2

[seanlinsley]

I'd be happy to submit a patch for this, but I have no idea where the related code exists. Can someone point me in the right direction?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to sean.ian.linsley from comment #2)
> I'd be happy to submit a patch for this, but I have no idea where the
> related code exists. Can someone point me in the right direction?

Great!  To get started with the code base, check out the DevTools hacking page[1].

The alert[2] could be replaced with a call to WebIDE's |reportError| function[3], so that it's displayed the way other errors are.

In this case, you'd likely do something like |window.parent.UI.reportError(...)|.

[1]: https://wiki.mozilla.org/DevTools/Hacking
[2]: http://hg.mozilla.org/mozilla-central/annotate/a4a5d4fb5e2e/browser/devtools/webide/content/addons.js#l51
[3]: http://hg.mozilla.org/mozilla-central/annotate/a4a5d4fb5e2e/browser/devtools/webide/content/webide.js#l308

Comment 4

[beracochea]

Attachment: fix1111294.patch

Patch proposal, could someone review it. Thanks

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8547261 [details] [diff] [review]
fix1111294.patch

Review of attachment 8547261 [details] [diff] [review]:
-----------------------------------------------------------------

Great, this looks good to me!

For future patches, be sure to set someone in the "review?" or "feedback?" flag, or else your patch might get lost.  Don't worry too much about who you pick, they will reassign the review if needed.

I have pushed this to our testing environment, and we'll land it assuming that looks good.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=562bf004c307

Comment 6

[beracochea]

Excellent! :). I'll mark the review or feedback flag next time.

Thanks!

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Tests look good.  A sheriff will land this patch soon.

Thanks for your contribution!  Feel free to look around for more patches to try. :)

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/6124563caa39

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6124563caa39