Closed
Bug 1111332
Opened 11 years ago
Closed 11 years ago
In-content Prefs - Remove strange border from help button
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 37
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
(Whiteboard: [testday-20150901])
Attachments
(1 file, 1 obsolete file)
|
958 bytes,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Right now, there's a strange gray border around the help button. It'd be nice to remove it to make it look nicer visually.
Also, the latest mockups also remove that border : http://invis.io/P61RQ2CEB
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8536149 [details] [diff] [review]
Patch
Review of attachment 8536149 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/themes/shared/in-content/common.inc.css
@@ +211,5 @@
>
> xul|*.help-button {
> min-width: 30px;
> border-radius: 2px;
> + border: 1px solid transparent;
Does the border still need to be here? If not, I would rather that you go with just changing this to `border-width:0;`
|
|
Assignee | |
Comment 3•11 years ago
|
||
Used border-width: 0;
Attachment #8536149 -
Attachment is obsolete: true
Attachment #8536149 -
Flags: review?(jaws)
Attachment #8536741 -
Flags: review?(jaws)
|
|
||
Updated•11 years ago
|
Attachment #8536741 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Comment 6•10 years ago
|
||
verified solved for a qa test day.
Status: RESOLVED → VERIFIED
Whiteboard: [testday-20150901]
You need to log in
before you can comment on or make changes to this bug.
Description
•