1111332 - In-content Prefs - Remove strange border from help button

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

Right now, there's a strange gray border around the help button. It'd be nice to remove it to make it look nicer visually. 

Also, the latest mockups also remove that border : http://invis.io/P61RQ2CEB

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8536149 [details] [diff] [review]
Patch

Review of attachment 8536149 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/shared/in-content/common.inc.css
@@ +211,5 @@
>  
>  xul|*.help-button {
>    min-width: 30px;
>    border-radius: 2px;
> +  border: 1px solid transparent;

Does the border still need to be here? If not, I would rather that you go with just changing this to `border-width:0;`

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch v1.1

Used border-width: 0;

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/3ad08cb24ae1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ad08cb24ae1

Comment 6

[Jerod Lycett]

verified solved for a qa test day.