Closed
Bug 1111387
Opened 9 years ago
Closed 9 years ago
[EME][MSE] Crash starting up EME during MSE shutdown
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
1.13 KB,
patch
|
cajbir
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I happened upon a crash while EME is starting up during browser shutdown. Main thread: xul.dll!mozilla::BlockingResourceBase::CheckAcquire() Line 271 C++ xul.dll!mozilla::OffTheBooksMutex::Lock() Line 382 C++ xul.dll!mozilla::Monitor::Lock() Line 35 C++ xul.dll!mozilla::MonitorAutoLock::MonitorAutoLock(mozilla::Monitor & aMonitor) Line 79 C++ xul.dll!mozilla::MediaTaskQueue::Dispatch(mozilla::TemporaryRef<nsIRunnable> aRunnable) Line 34 C++ xul.dll!mozilla::TrackBuffer::QueueInitializeDecoder(mozilla::SourceBufferDecoder * aDecoder) Line 356 C++ xul.dll!nsRunnableMethodImpl<bool (__thiscall mozilla::TrackBuffer::*)(mozilla::SourceBufferDecoder *),mozilla::SourceBufferDecoder *,1>::Run() Line 365 C++ xul.dll!nsThread::ProcessNextEvent(bool aMayWait, bool * aResult) Line 830 C++ xul.dll!NS_ProcessNextEvent(nsIThread * aThread, bool aMayWait) Line 265 C++ TrackBuffer::mTaskQueue is null, but TrackBuffer::QueueInitializeDecoder is dereferencing it. I assume that TrackBuffer::SetCDMProxy() is dispatching a task to call TrackBuffer::QueueInitializeDecoder(), which is running after we've run TrackBuffer::Shutdown() which nulls mTaskQueue. I guess we should null-check mTaskQueue in TrackBuffer::QueueInitializeDecoder()?
Assignee | ||
Comment 1•9 years ago
|
||
Add the obvious null-check...
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8536219 -
Flags: review?(cajbir.bugzilla)
Updated•9 years ago
|
Attachment #8536219 -
Flags: review?(cajbir.bugzilla) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6461117552cd
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6461117552cd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 4•9 years ago
|
||
Comment on attachment 8536219 [details] [diff] [review] Patch: Add null check Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve Flash video. [Describe test coverage new/current, TBPL]: Landed on m-c. [Risks and why]: Low. Clean and straightforward change. [String/UUID change made/needed]: None.
Attachment #8536219 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8536219 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•9 years ago
|
||
Mass update firefox-status to track EME uplift.
status-firefox38:
--- → fixed
status-firefox39:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•