No partial suggestions for Firefox ESR release, or Thunderbird release, in ship-it

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nthomas, Assigned: sylvestre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
I'd marked Firefox-31.3.0esr-build2 and Firefox-31.2.0esr-build3 as shipped, but no suggestions were offered when starting to enter 31.4.0esr release.

Follow on from 1049689.
(Reporter)

Comment 1

3 years ago
Similar problem for Thunderbird release. Firefox & Thunderbird beta are both fine.
Summary: No partial suggestions for Firefox ESR release in ship-it → No partial suggestions for Firefox ESR release, or Thunderbird release, in ship-it
Sylvestre, can you have a look at this?
Flags: needinfo?(sledru)
(Assignee)

Comment 3

3 years ago
With pleasure!
Assignee: nobody → sledru
Flags: needinfo?(sledru)
(Assignee)

Comment 4

3 years ago
Created attachment 8537221 [details] [diff] [review]
0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

here it is
Attachment #8537221 - Flags: review?(bhearsum)
Comment on attachment 8537221 [details] [diff] [review]
0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

Review of attachment 8537221 [details] [diff] [review]:
-----------------------------------------------------------------

::: kickoff/static/suggestions.js
@@ +143,2 @@
>          releaseVersion = version.match(versionRE);
>          if (releaseVersion != null) {

Is this changed regex still going to work for non-esrs? It looks to me like it won't match anything except ESRs now...
(Assignee)

Comment 6

3 years ago
the regexp is this one:
versionRE = /^\d+\.\d+$|^\d+\.\d\.\d+|^\d+\.[\d.]*\desr$/;

so, it catches X.Y, X.Y.Z and X.Y.Zesr
(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> the regexp is this one:
> versionRE = /^\d+\.\d+$|^\d+\.\d\.\d+|^\d+\.[\d.]*\desr$/;
> 
> so, it catches X.Y, X.Y.Z and X.Y.Zesr

Whoops, my bad!
Attachment #8537221 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 8

3 years ago
Comment on attachment 8537221 [details] [diff] [review]
0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=a5847a13052dd31f7b1d8d3625b4f4e2de9ef5d4
Attachment #8537221 - Flags: checked-in+
(Assignee)

Comment 9

3 years ago
deployed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.