1111409 - No partial suggestions for Firefox ESR release, or Thunderbird release, in ship-it

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

I'd marked Firefox-31.3.0esr-build2 and Firefox-31.2.0esr-build3 as shipped, but no suggestions were offered when starting to enter 31.4.0esr release.

Follow on from 1049689.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Similar problem for Thunderbird release. Firefox & Thunderbird beta are both fine.

Comment 2

[[e-mail] (:bhearsum)]

Sylvestre, can you have a look at this?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

With pleasure!

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

here it is

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8537221 [details] [diff] [review]
0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

Review of attachment 8537221 [details] [diff] [review]:
-----------------------------------------------------------------

::: kickoff/static/suggestions.js
@@ +143,2 @@
>          releaseVersion = version.match(versionRE);
>          if (releaseVersion != null) {

Is this changed regex still going to work for non-esrs? It looks to me like it won't match anything except ESRs now...

Comment 6

[Sylvestre Ledru [:Sylvestre]]

the regexp is this one:
versionRE = /^\d+\.\d+$|^\d+\.\d\.\d+|^\d+\.[\d.]*\desr$/;

so, it catches X.Y, X.Y.Z and X.Y.Zesr

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> the regexp is this one:
> versionRE = /^\d+\.\d+$|^\d+\.\d\.\d+|^\d+\.[\d.]*\desr$/;
> 
> so, it catches X.Y, X.Y.Z and X.Y.Zesr

Whoops, my bad!

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8537221 [details] [diff] [review]
0001-Bug-1111409-Also-generate-partial-for-tb-fx-esr.patch

http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=a5847a13052dd31f7b1d8d3625b4f4e2de9ef5d4

Comment 9

[Sylvestre Ledru [:Sylvestre]]

deployed.