1111546 - Enable client/inspector/shared/test/browser_styleinspector_tooltip-closes-on-new-selection.js in e10s

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Patrick Brosset <:pbro>]

Test /browser/devtools/styleinspector/test/browser_styleinspector_tooltip-closes-on-new-selection.js frequently fails with E10S enabled.

See this try build for example: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5fab0cdd5353

It seems to be timing out here:

function* testRuleView(ruleView, inspector) {
  info("Showing the tooltip");
  let tooltip = ruleView.tooltips.previewTooltip;
  let onShown = tooltip.once("shown");
  tooltip.show();
  yield onShown; // --> Times out here
  ...
}

tooltip here is a Tooltip object as defined here: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#177

Calling show just calls this.panel.openPopup(...) (where this.panel is the XUL panel used by the tooltip).
And the Tooltip class emits "shown" events when the XUL panel does.

I've never seen this test fail without E10S.

Comment 1

[Patrick Brosset <:pbro>]

Test /browser/devtools/styleinspector/test/browser_styleinspector_tooltip-size.js suffers from the exact same symptoms, so I'm going to add it to this bug.

Instead of failing to show the XUL panel, it fails to hide it (but that may be intermittent too):

  let onHidden = tooltip.once("hidden");
  tooltip.hide();
  yield onHidden;

Comment 2

[Patrick Brosset <:pbro>]

Depends on bug 1104908 since that's the bug I'm going to disable both of these tests in.

Comment 3

[Julian Descottes [:jdescottes]]

Inspector bug triage. Filter on CLIMBING SHOES

Tests are still disabled.

Comment 5

[Julian Descottes [:jdescottes]]

This _might_ be fixed now that we switched to the HTMLTooltip. It passes with --verify for me, let's check on try, enable and fix if it becomes intermittent again.

Comment 6

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a410108e9d67ba125288e5268e89b9b4a74ef367

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1111546 - Enable browser_styleinspector_tooltip-closes-on-new-selection.js;

Review commit: https://reviewboard.mozilla.org/r/259290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259290/

Comment 8

[Patrick Brosset <:pbro>]

Comment on attachment 8994758 [details]
Bug 1111546 - Enable browser_styleinspector_tooltip-closes-on-new-selection.js;

https://reviewboard.mozilla.org/r/259290/#review266264

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8273ed227bbc
Enable browser_styleinspector_tooltip-closes-on-new-selection.js;r=pbro

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8273ed227bbc