1111655 - Rooms loadtest needs updating

Status: VERIFIED FIXED

(Hello (Loop) :: Server, defect)

Description

[Richard Pappalardo [:rpapa][:rpappalardo]]

rooms loadtest needs updating to reflect new way to handle the number of people in a room.

looks like /loadtests/loadtest/rooms.py is set to:
MAX_NUMBER_OF_PEOPLE_JOINING = 5 # Pick a random number between 1 and this value.
shouldn't this also be set = 2?

Currently running loadtests shows intermittent failures with following error:
Participant Creation failed with code 400: {"code":400,"errno":202,"error":"The room is full."}:
https://loads.services.mozilla.com/run/bc445413-b0ac-4d80-90e6-a02d34cd1e05
https://loads.services.mozilla.com/run/7d1f2503-8e4b-4744-ad4e-20f6148da1fc

Comment 1

[Rémy Hubscher (:natim)]

This should have been fixed with 0.14.3

Comment 2

[Richard Pappalardo [:rpapa][:rpappalardo]]

Hi Remy - 

Seems like the issue still persists on stage.  Could you note what was changed in 0.14.3?  I still see 
MAX_NUMBER_OF_PEOPLE_JOINING = 5 in the rooms test.  Not sure if that's related to the issue, but I thought you could only have 2 people in a room at a time.

Just kicked off a short loadtest with 60 users & 5 mins into the test I see:

5 occurrences:
Participant Creation failed with code 400: {"code":400,"errno":202,"error":"The room is full."}

https://loads.services.mozilla.com/run/d859f877-3967-4021-b870-0677e27f7b06

Comment 3

[Rémy Hubscher (:natim)]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #2)
> Hi Remy - 

Hi Richard,

> Seems like the issue still persists on stage.  Could you note what was
> changed in 0.14.3?  I still see 
> MAX_NUMBER_OF_PEOPLE_JOINING = 5 in the rooms test.  Not sure if that's
> related to the issue, but I thought you could only have 2 people in a room
> at a time.

The client only works with two right now but the server can handle much more.

In the loadtest we are testing with 5.

> Just kicked off a short loadtest with 60 users & 5 mins into the test I see:
> 
> 5 occurrences:
> Participant Creation failed with code 400:
> {"code":400,"errno":202,"error":"The room is full."}

I think it is related to the fact that we now keep a place for the room owner. (I always can enter the room)

> https://loads.services.mozilla.com/run/d859f877-3967-4021-b870-0677e27f7b06

Thank you for pointing this.

Comment 4

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #275.

Comment 5

[Alexis Metaireau (:alexis)]

Comment on attachment 8542940 [details] [review]
Link to Github PR — #275.

Thanks Remy! https://github.com/mozilla-services/loop-server/commit/c6007e742887ff2a97bdafa52bdfe012d60d2289

(This patch makes sure the room owner joins first in order to always keep her a room).

Comment 6

[Richard Pappalardo [:rpapa][:rpappalardo]]

Good job, Remy!
https://loads.services.mozilla.com/run/2b58ff2a-dc34-419d-aea2-ab3766b993b5

Comment 7

[Rémy Hubscher (:natim)]

You're welcome :)