1111658 - SIM Toolkit dialog are improperly placed with software home button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[:gerard-majax]

Reproduced on master, with SHB enabled on Xperia ZR (720p), with Bouygues Telecom SIM.

STR:
 0. Go to SIM Toolkit
 1. Go into the Services menu, then Pratique
 2. Tap on Trafic, Répondeur, or anything inside that will trigger a phone call
 3. We get a warning dialog that a call will be placed

Expected:
 The interface should not have its OK/Cancel button hidden by SHB

Actual:
 The interface have its OK/Cancel button hidden by SHB

Comment 1

[:gerard-majax]

Attachment: 2014-12-15-16-30-10.png

Michael, I think you worked on SHB ?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Let's block on this for 2.2.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Hey Tim, the issue here is that the dialog is not resized when a STK message is received.

Plase take a look when you get a chance

Thanks!

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Adding whiteboard tag so we can track this on our wiki. Thanks for taking this Manuel!

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8537123 [details] [review]
Proposed patch

I am pretty sure this is not the right way to calculate height for v2.2 but Alive can confirm.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8537123 [details] [review]
Proposed patch

Left a question, please answer before going further, thx

Comment 7

[Manuel Casas Barrado [:mancas]]

Hey Alive, please take a look at my comment in github

Thanks for your time

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8537123 [details] [review]
Proposed patch

r+ for blocker; we should have the same resize mechanism for system dialogs - and we should move stk dialog to use system dialog as well.

Comment 9

[Manuel Casas Barrado [:mancas]]

I've opened a follow up to move the stk dialog.

Thanks Alive!

Comment 10

[Ryan VanderMeulen (PTO, back 6-April)]

Master: https://github.com/mozilla-b2g/gaia/commit/ec89735b5606590f4720e8ee2a42d4b0bba4352c