1111772 - mach run doesn't work with OS X Universal build

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Liz Henry (:lizzard)]

I just built Nightly on 10.10. The binaries are installed in $topdirectory/obj-x86_64-apple-darwin14.0.0/i386/dist/Nightly.app  but mach run doesn't detect that. Somewhere in either mach or in the various mac config files, I suspect it's looking in the wrong path. Maybe this is a difference between 10.9 and 10.10. Is there some way I can fix this in .mozconfig?

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

It's failing here: http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mach_commands.py#908

> try:
>   binpath = self.get_binary_path('app')
> except Exception as e:
>   print("It looks like your program isn't built.",
>         "You can run |mach build| to build it.")
>   print(e)
>   return 1

get_binary_path is defined in http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/base.py#302

The OS_ARCH Darwin block is written by schien, so CCing in hope for more insights.

Comment 2

[Liz Henry (:lizzard)]

Thanks Archaeopteryx!  That is just about where I got up to yesterday afternoon. 

I was using this suggested .mozconfig:
https://developer.mozilla.org/en-US/docs/Configuring_Build_Options#Firefox.2C_Default_Release_Configuration

Using this .mozconfig instead seemed to fix the problem.   

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Mac_OS_X_Prerequisites#4._Configure_the_Mozilla_source_tree_for_build_options

So this may be something to update in the documentation (the sample mozconfig file), or fix in the Darwin based code or maybe both.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

What I did before is adding a special case for XULRunner, which is not the case in this bug. @gps may have better insight than me, so ni? @gps.

Liz, can you attached the original error message. It'll be super helpful for people who want to debug this.

Comment 4

[Gregory Szorc [:gps]]

I'm not sure what you are trying to do, but a lot of workflows don't require a universal OS X build. Delete the mozconfig you grabbed from https://developer.mozilla.org/en-US/docs/Configuring_Build_Options#Firefox.2C_Default_Release_Configuration and build with the default settings (which should be sufficient for most developers). Only add values to your mozconfig if you know you need them.

Comment 5

[(not currently active) Ted Mielczarek]

(In reply to Liz Henry :lizzard from comment #2)
> Thanks Archaeopteryx!  That is just about where I got up to yesterday
> afternoon. 
> 
> I was using this suggested .mozconfig:
> https://developer.mozilla.org/en-US/docs/Configuring_Build_Options#Firefox.
> 2C_Default_Release_Configuration

Oh, gross, we should remove that from the docs. We definitely should not be recommending the use of a universal build in the build docs.

Comment 6

[Michael Shal [:mshal]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> (In reply to Liz Henry :lizzard from comment #2)
> > I was using this suggested .mozconfig:
> > https://developer.mozilla.org/en-US/docs/Configuring_Build_Options#Firefox.
> > 2C_Default_Release_Configuration
> 
> Oh, gross, we should remove that from the docs. We definitely should not be
> recommending the use of a universal build in the build docs.

I removed the suggestions to use universal builds and xulrunner builds from that page since neither are supported anymore.

Comment 7

[Gregory Szorc [:gps]]

So can we close this bug since universal builds are no longer supported?

Comment 8

[(not currently active) Ted Mielczarek]

Yeah, this shouldn't be an issue anymore.