Closed Bug 1111815 Opened 7 years ago Closed 7 years ago

add accessibility checks for isElementDisplayed

Categories

(Testing :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: pi-marionette-userinput, Whiteboard: [affects=a11y])

Attachments

(1 file)

We need to check that the element is visible to accessibility API when it is also displayed otherwise. Similarly, when the element is not displayed we need to make sure that the accessibility API can't see it either.
Attached patch 1111815 patch v1Splinter Review
Attachment #8538539 - Flags: review?(dburns)
Comment on attachment 8538539 [details] [diff] [review]
1111815 patch v1

Review of attachment 8538539 [details] [diff] [review]:
-----------------------------------------------------------------

I should have picked this up in the last review, could we maybe make the test names slightly more descriptive

e.g. test_is_element_displayed could be split into 2 tests and be test_element_visible_but_not_visible_to_accessbility and test_element_is_visible_to_accessibility
Attachment #8538539 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/470ccde0d51a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.