Closed
Bug 1111837
Opened 10 years ago
Closed 10 years ago
Favicon methods should take failure callbacks
Categories
(Firefox for iOS :: Favicons, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wesj, Unassigned)
References
Details
Attachments
(1 file)
The new bookmarks code usually takes a success and a failure callback. The favicon callback code doesn't really have error handling. I think we should probably make sure the API's match, so I'll failure handlers there.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8536844 -
Flags: review?(bnicholson)
|
|
Reporter | |
Comment 2•10 years ago
|
||
Oh I thought you r+ and merged it. Do you want me to remove it?
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8536844 [details] [review]
Pull request
Heh, it's fine. I was just waiting for an answer to the single vs. multiple callbacks question. We can change it later if we change our minds.
Attachment #8536844 -
Flags: review?(bnicholson) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Component: General → Favicons
You need to log in
before you can comment on or make changes to this bug.
Description
•