1111970 - [Wifi Direct] group owner's ip is not populated to content properly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

MozWifiP2pManager.groupOwner.ip is always undefined due to [1]. It should be |gateways[0]|

[1] http://hg.mozilla.org/mozilla-central/file/5d6e0d038f95/dom/wifi/WifiP2pManager.jsm#l1184

Comment 1

[Henry Chang [:hchang]]

Attachment: omni.ja (with modified WifiP2pManager.js)

Comment 2

[Henry Chang [:hchang]]

Attachment: Bug111970.patch

Comment 3

[Henry Chang [:hchang]]

Attachment: Testing patch for fxos-web-server

Comment 4

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=30cc3ed4e9a4

Comment 5

[Henry Chang [:hchang]]

For those who have a hard time building gecko, push the attachment omni.ja to system/b2g/

$ adb push omni.ja system/b2g/

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to Henry Chang [:henry] from comment #5)
> For those who have a hard time building gecko, push the attachment omni.ja
> to system/b2g/
> 
> $ adb push omni.ja system/b2g/

Thanks Henry! This patch worked for me. I'm now able to connect to the peer by getting its ipAddress.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Can we get this landed?

Comment 8

[Henry Chang [:hchang]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #6)
> (In reply to Henry Chang [:henry] from comment #5)
> > For those who have a hard time building gecko, push the attachment omni.ja
> > to system/b2g/
> > 
> > $ adb push omni.ja system/b2g/
> 
> Thanks Henry! This patch worked for me. I'm now able to connect to the peer
> by getting its ipAddress.

Oops I forgot to request to review. Will land after getting reviewed.
Thanks!

Comment 9

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8536992 [details] [diff] [review]
Bug111970.patch

Review of attachment 8536992 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 10

[Diego Marcos [:dmarcos]]

Thanks guys. This is ready to land right?

Comment 11

[Diego Marcos [:dmarcos]]

Henry. I noticed that if push omni.ja to the latest gecko my phone doesn't boot.

It works fine with the build 20141215040201

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/251a3de5eba6

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/251a3de5eba6

Comment 14

[Doug Sherk (:drs) (inactive)]

Henry, we're finding the functionality in this patch very flaky. We can generally get 1-2 connections going before needing to reboot. This is making iteration on an important WiFi Direct project very difficult. Is this known, is there any eta, etc? Thanks for any help you can provide.

Comment 15

[Henry Chang [:hchang]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #14)
> Henry, we're finding the functionality in this patch very flaky. We can
> generally get 1-2 connections going before needing to reboot. This is making
> iteration on an important WiFi Direct project very difficult. Is this known,
> is there any eta, etc? Thanks for any help you can provide.

Hi,

I don't it has anything to do with this patch. Can you elaborate the
issue you met or file a bug?

Thanks :)

Comment 16

[Vincent Chang[:vchang][changyihsin]]

Hi Doug, can you describe in more detail about your problem? Which device do you use?

Comment 17

[Doug Sherk (:drs) (inactive)]

(In reply to Vincent Chang[:vchang] from comment #16)
> Hi Doug, can you describe in more detail about your problem? Which device do
> you use?

Filed bug 1119853.