Closed Bug 1112021 Opened 5 years ago Closed 5 years ago

Extra outline/overlap of local video shadow on top of remote video

Categories

(Hello (Loop) :: Client, defect)

All
macOS
defect
Not set
Points:
1

Tracking

(firefox35+ fixed, firefox36+ fixed, firefox37 fixed)

RESOLVED FIXED
mozilla37
Iteration:
37.1
Tracking Status
firefox35 + fixed
firefox36 + fixed
firefox37 --- fixed

People

(Reporter: standard8, Unassigned)

Details

(Whiteboard: [good first verify])

Attachments

(5 files, 2 obsolete files)

Best to see the attached screenshots - we have a line that's overlaying the remote video.
This patch removes the drop shadows applied to room local video streams, and also update the room preview to use a black background.
Attachment #8537928 - Flags: review?(standard8)
Grmbl as :sevaan pointed out on IRC, drop shadows are still applied on the desktop conversation window local video. Will amend the patch.
Actually removed the drop shadow from the desktop conversation window local video element.
Attachment #8537928 - Attachment is obsolete: true
Attachment #8537928 - Flags: review?(standard8)
Attachment #8538599 - Flags: review?(standard8)
Comment on attachment 8538599 [details] [diff] [review]
Remove drop shadows from Loop room preview.

Review of attachment 8538599 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/content/shared/css/conversation.css
@@ +548,5 @@
>  .room-conversation .OT_publisher .OT_video-container video {
>    background-color: transparent; /* avoid visually obvious letterboxing */
>  }
>  
> +.fx-embedded .room-conversation .room-preview .OT_publisher .OT_video-container,

For some reason, this section isn't in my version of the file. The change looks fine though, so fix the bitrot and keep it or leave it appropriately.
Attachment #8538599 - Flags: review?(standard8) → review+
https://hg.mozilla.org/integration/fx-team/rev/0d9c5bf15946
Iteration: --- → 37.1
Points: --- → 1
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/0d9c5bf15946
Assignee: nobody → nperriault
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8538599 [details] [diff] [review]
Remove drop shadows from Loop room preview.

Approval Request Comment
[Feature/regressing bug #]: Visual anomaly introduced when fixing the self view to be accurate
[User impact if declined]:  Extra shadow would continue to be visible which is very annoying
[Describe test coverage new/current, TBPL]: easily tested and verified manually
[Risks and why]: Very low risk to Hello, no risk outside of Hello.
[String/UUID change made/needed]: no strings
Attachment #8538599 - Flags: approval-mozilla-beta?
Attachment #8538599 - Flags: approval-mozilla-aurora?
[Tracking Requested - why for this release]:
See Comment 11
Attachment #8538599 - Flags: approval-mozilla-beta?
Attachment #8538599 - Flags: approval-mozilla-beta+
Attachment #8538599 - Flags: approval-mozilla-aurora?
Attachment #8538599 - Flags: approval-mozilla-aurora+
Flags: qe-verify-
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.