1112021 - Extra outline/overlap of local video shadow on top of remote video

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

Attachment: Screen shot - no remote video

Best to see the attached screenshots - we have a line that's overlaying the remote video.

Comment 1

[Mark Banner (:standard8)]

Attachment: Screen shot - with remote video

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Remove drop shadows from Loop room preview.

This patch removes the drop shadows applied to room local video streams, and also update the room preview to use a black background.

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Capture with patch applied (drop shadows removed)

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Capture with patch applied (using a black background for uncropped local preview stream)

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Grmbl as :sevaan pointed out on IRC, drop shadows are still applied on the desktop conversation window local video. Will amend the patch.

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Remove drop shadows from Loop room preview.

Actually removed the drop shadow from the desktop conversation window local video element.

Comment 7

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: capture with drop shadows actually removed.png

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8538599 [details] [diff] [review]
Remove drop shadows from Loop room preview.

Review of attachment 8538599 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/content/shared/css/conversation.css
@@ +548,5 @@
>  .room-conversation .OT_publisher .OT_video-container video {
>    background-color: transparent; /* avoid visually obvious letterboxing */
>  }
>  
> +.fx-embedded .room-conversation .room-preview .OT_publisher .OT_video-container,

For some reason, this section isn't in my version of the file. The change looks fine though, so fix the bitrot and keep it or leave it appropriately.

Comment 9

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/0d9c5bf15946

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d9c5bf15946

Comment 11

[Maire Reavy [:mreavy]]

Comment on attachment 8538599 [details] [diff] [review]
Remove drop shadows from Loop room preview.

Approval Request Comment
[Feature/regressing bug #]: Visual anomaly introduced when fixing the self view to be accurate
[User impact if declined]:  Extra shadow would continue to be visible which is very annoying
[Describe test coverage new/current, TBPL]: easily tested and verified manually
[Risks and why]: Very low risk to Hello, no risk outside of Hello.
[String/UUID change made/needed]: no strings

Comment 12

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
See Comment 11

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dc6001f40b63

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2a95973fa3e2