Closed Bug 1112054 Opened 5 years ago Closed 5 years ago

Disable WebSockets in workers for 35

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox35 + fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Keywords: dev-doc-complete, relnote)

Attachments

(2 files, 1 obsolete file)

Attached patch ws.patch (obsolete) — Splinter Review
They are too unstable to have them enabled in beta.
Attachment #8537174 - Flags: review?(bugs)
Comment on attachment 8537174 [details] [diff] [review]
ws.patch

Approval Request Comment
[Feature/regressing bug #]: 504553
[User impact if declined]: We had too many security bugs about this feature. Better to test it a bit more in aurora.
[Describe test coverage new/current, TBPL]: n/a
[Risks and why]: n/a
[String/UUID change made/needed]: n/a
Attachment #8537174 - Flags: approval-mozilla-beta?
Comment on attachment 8537174 [details] [diff] [review]
ws.patch

Review of attachment 8537174 [details] [diff] [review]:
-----------------------------------------------------------------

I actually prefer this:

// WebSocket in workers are disabled by default.
#ifdef RELEASE_BUILD
pref("dom.workers.websocket.enabled", false);
#else
pref("dom.workers.websocket.enabled", true);
#endif
Yes, that would be better.
 Do all the tests pass without ws?
Comment on attachment 8537174 [details] [diff] [review]
ws.patch

So, new patch coming?
Attachment #8537174 - Flags: review?(bugs)
[Tracking Requested - why for this release]: Unstable new feature with various known issues that needs to be turned off before release.
Attached patch ws.patchSplinter Review
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=93ef5f71e5a3
Attachment #8537174 - Attachment is obsolete: true
Attachment #8537174 - Flags: approval-mozilla-beta?
Attachment #8537268 - Flags: review?(bugs)
Keywords: relnote
Attachment #8537268 - Flags: review?(bugs) → review+
Depends on: 1091016
Tracking - and this should be in the nomination queue for Monday Dec 22 beta in order to ensure time for testing with it disabled before ship.
Please put this up for beta approval when you get a chance.
Flags: needinfo?(amarchesini)
Comment on attachment 8537268 [details] [diff] [review]
ws.patch

Approval Request Comment
[Feature/regressing bug #]: 504553
[User impact if declined]: websocket enabled in beta with possible crashes
[Describe test coverage new/current, TBPL]: tbpl
[Risks and why]: we had too many regressions and we need this patch (and the depending one) in beta.
[String/UUID change made/needed]: none
Flags: needinfo?(amarchesini)
Attachment #8537268 - Flags: approval-mozilla-beta?
Attachment #8537268 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/1c47d7b0b7fd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Summary: Disable WebSockets in workers on beta → Disable WebSockets in workers for 35
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #11)
> Test fix: https://hg.mozilla.org/releases/mozilla-beta/rev/736654db5a40

Ehsan, thanks.
And Aurora36 then I presume?
Attached patch auroraSplinter Review
Approval Request Comment
[Feature/regressing bug #]: 504553
[User impact if declined]: websocket enabled in beta with possible crashes
[Describe test coverage new/current, TBPL]: tbpl
[Risks and why]: we had too many regressions and we need this patch (and the depending one) in beta.
[String/UUID change made/needed]: none
Flags: needinfo?(amarchesini)
Attachment #8540833 - Flags: approval-mozilla-aurora?
I've removed the note that this feature is enabled from Firefox 35 for developers: https://developer.mozilla.org/en-US/Firefox/Releases/35#Interfaces.2FAPIs.2FDOM

Finally, I added the worker compatibility information to the compatibility table here: https://developer.mozilla.org/en-US/docs/WebSockets#Browser_compatibility

So we should be ready for Firefox 36 release of this feature; please let us know if it gets moved further out.
Attachment #8540833 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Blocks: 1115678
Hello, 

I'm currently trying to develop a web application that relies on WebSockets to run in Workers. The current Firefox release: 37.0.2 still does not support websockets in workers by default. Is there any indication that this feature will be available with out modifying the 'dom.workers.websocket.enabled' flag?

Thank you in advance,
Vlad
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.