1112086 - Flash plugin getting blocked by an overzealous entry in the blocklist

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open Firefox and go to http://www.intel.com/museumofme/mobile/index.htm
2. Put Firefox in background and wait for a few minutes
3. Exit Firefox from app menu or from Task Manager
3. Reopen Firefox and go again to http://www.intel.com/museumofme/mobile/index.htm

Expected results:
- Flash content should be correctly displayed.

Actual results:
- Flash doesn't work. Grey content is displayed.
Note: 
-flash will work again only with a clean profile.
-even if you change the "dom.ipc.plugins.flash.disable-protected-mode" pref to true, flash still does not work

Comment 1

[Aaron Train [:aaronmt]]

Can you run a debug build and attach a log-cat?

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Attachment: logflash.txt

Here are the attached the logs.

Comment 5

[Aaron Train [:aaronmt]]

From the bug above, other STR

> Steps to reproduce:
> 
> For more background look at this thread:
> https://support.mozilla.org/en-US/questions/1036546
> 
> Install firefox for android. Install flash.
> 
> Go to https://settings.adobe.com/ or any other site that uses flash. Force
> stop firefox or wait a day so that plugin block list gets updated. Then
> attempt to visit a flash page. Instead of flash content you will have a gray
> box.
> 
> 
> 
> 
> 
> Actual results:
> 
> There will be no option to enable the flash content and you will just have a
> grey box as there is no option presented to allow the plugin to be allowed. 
> 
> 
> Expected results:
> 
> An option to start content should have been presented. Otherwise there needs
> to be a way to modify blocked list since adobe no longer provides new flash
> plugins.

Comment 6

[ram_80]

(In reply to Aaron Train [:aaronmt] from comment #5)
> From the bug above, other STR
> 
> > Steps to reproduce:
> > 
> > For more background look at this thread:
> > https://support.mozilla.org/en-US/questions/1036546
> > 
> > Install firefox for android. Install flash.
> > 
> > Go to https://settings.adobe.com/ or any other site that uses flash. Force
> > stop firefox or wait a day so that plugin block list gets updated. Then
> > attempt to visit a flash page. Instead of flash content you will have a gray
> > box.
> > 
> > 
> > 
> > 
> > 
> > Actual results:
> > 
> > There will be no option to enable the flash content and you will just have a
> > grey box as there is no option presented to allow the plugin to be allowed. 
> > 
> > 
> > Expected results:
> > 
> > An option to start content should have been presented. Otherwise there needs
> > to be a way to modify blocked list since adobe no longer provides new flash
> > plugins.

I believe this bug is due to plugin blocking. Because if you set extensions.blocklist.enable=false, then firefox works as expected. If there was a way to allow for blocked content I believe it would work.

Comment 7

[Aaron Train [:aaronmt]]

Which version of Android Flash is installed on the device? The last available version on the Adobe Archives? (http://helpx.adobe.com/flash-player/kb/archived-flash-player-versions.html, version: 11.1.115.81)?

Comment 8

[ram_80]

Yes, I am using version: 11.1.115.81. However I believe this version is on blocked plugin list.

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

The plugin cannot be blocked because of the version, because we don't report that version (11.1.115.81) to gecko anywhere. See bug 1112143. The fact that it worked when the pref was toggled is probably just a coincident.

Comment 10

[ram_80]

It might be coincidence, but when extensions.blocklist.enable=true you get a grey box, but if you set extensions.blocklist.enable=false you get the tap to enable flash which allows flash to work. If you go to about:plugins when

extensions.blocklist.enable=false

You get the following:

State: Enabled (STATE_VULNERABLE_UPDATE_AVAILABLE)

When

extensions.blocklist.enable=true

You get the following:

State: Enabled

Comment 11

[Aaron Train [:aaronmt]]

We should indeed re-evaluate this if this is what is happening on release right now

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

a regression window would be useful here

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to ram_80 from comment #10)
I stand corrected! It does look like blocking is at work here. Weirdness. I'll look into it more today.

Comment 14

[James Willcox (:snorp) ([e-mail]) (he/him)]

It looks like click-to-play is busted on the second attempt a page is loaded (and only after restart?). We get a null eventType here[0] in the broken state.

[0] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/PluginHelper.js#157

Comment 15

[James Willcox (:snorp) ([e-mail]) (he/him)]

Found a regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e90536aa55dd&tochange=df3fc7cb7e80

The change that causes the breakage is here: https://hg.mozilla.org/mozilla-central/rev/54b831a0ce00

Specifically, the first hunk of that patch. Building locally without that change (and fresh profile) makes things work again.

Comment 16

[James Willcox (:snorp) ([e-mail]) (he/him)]

Sorry, it's the second hunk. The one that adds this:

    1.24 +      <emItem  blockID="i792" id="{8f894ed3-0bf2-498e-a103-27ef6e88899f}">
    1.25 +                        <versionRange  minVersion="0" maxVersion="*" severity="3">
    1.26 +                    </versionRange>
    1.27 +                    <prefs>
    1.28 +              </prefs>
    1.29 +    </emItem>

Comment 17

[Kevin Brosnan [Ex-Mozilla]]

That seems unlikely https://bugzilla.mozilla.org/show_bug.cgi?id=1109795 and https://addons.mozilla.org/en-US/firefox/blocked/p796 updated the Linux block recently.

Comment 18

[Dave Townsend [:mossop]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #17)
> That seems unlikely https://bugzilla.mozilla.org/show_bug.cgi?id=1109795 and
> https://addons.mozilla.org/en-US/firefox/blocked/p796 updated the Linux
> block recently.

Flash plugin on Android reports its version as "11.1 r115" so that's certainly within the blockrange added by bug 1109795:

<pluginItem  blockID="p796">
  <match name="filename" exp="libflashplayer\.so" />
  <versionRange  minVersion="0" maxVersion="11.2.202.424" severity="0" vulnerabilitystatus="1"
  </versionRange>
  <infoURL>https://get.adobe.com/flashplayer/</infoURL>
</pluginItem>

The problem is that the block added by bug blocks the plugin by filename only. It should probably be updated to only block with os="Linux"

Comment 19

[Dave Townsend [:mossop]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #15)
> Found a regression range:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=e90536aa55dd&tochange=df3fc7cb7e80
> 
> The change that causes the breakage is here:
> https://hg.mozilla.org/mozilla-central/rev/54b831a0ce00
> 
> Specifically, the first hunk of that patch. Building locally without that
> change (and fresh profile) makes things work again.

Were you completely deleting your profile folder between each test? That's pretty much the only sure way to make only a change to the application blocklist have an actual effect on the plugins.

Comment 20

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Dave Townsend [:mossop] from comment #19)
> (In reply to James Willcox (:snorp) ([e-mail]) from comment #15)
> > Found a regression range:
> > https://hg.mozilla.org/mozilla-central/
> > pushloghtml?fromchange=e90536aa55dd&tochange=df3fc7cb7e80
> > 
> > The change that causes the breakage is here:
> > https://hg.mozilla.org/mozilla-central/rev/54b831a0ce00
> > 
> > Specifically, the first hunk of that patch. Building locally without that
> > change (and fresh profile) makes things work again.
> 
> Were you completely deleting your profile folder between each test? That's
> pretty much the only sure way to make only a change to the application
> blocklist have an actual effect on the plugins.

mozregression does start with a fresh profile each time, yeah.

Comment 21

[Dave Townsend [:mossop]]

Sorry, I don't have any ability to fix the blocklist. Jorge maybe

Comment 22

[Aaron Train [:aaronmt]]

[Tracking Requested - why for this release]:

Comment 23

[Jorge Villalobos [:jorgev] (he/him)]

I added OS=Linux to the block in dev and prod. We'll need someone to make sure that the block still works on Linux and it's no longer blocking on Android. Juan, can you help with this?

Comment 24

[James Willcox (:snorp) ([e-mail]) (he/him)]

Android seems to be working again

Comment 25

[Ioana Chiorean]

Checked on Nexus 5 ( Android 5.0.1) and Galaxy Nexus ( Android 4.3) - Works fine again on Android.

Comment 26

[Jorge Villalobos [:jorgev] (he/him)]

Aaron, did you verify that the block still works correctly on Linux?

Comment 27

[Aaron Train [:aaronmt]]

(In reply to Jorge Villalobos [:jorgev] from comment #26)
> Aaron, did you verify that the block still works correctly on Linux?

There's a NI on Juan for that.

Comment 28

[juan becerra [:juanb]]

I tested on Linux Mint using Firefox 34.0.5 and the Flash versions below. The older version was blocklisted (click-to-pay) whereas the latest one, ...425, wasn't. 

    File: libflashplayer.so
    Path: /usr/lib/adobe-flashplugin/libflashplayer.so
    Version: 11.2.202.411
    State: Enabled (STATE_VULNERABLE_UPDATE_AVAILABLE)
    Shockwave Flash 11.2 r202

    File: libflashplayer.so
    Path: /usr/lib/adobe-flashplugin/libflashplayer.so
    Version: 11.2.202.425
    State: Enabled
    Shockwave Flash 11.2 r202

Comment 29

[Jorge Villalobos [:jorgev] (he/him)]

Thank you, Juan. Looks like we're good then.