1112098 - Customize UI shows 'Sign in to Sync' even when signed in

Status: RESOLVED DUPLICATE of bug 1214801

(Firefox :: Sync, defect, P2)

Description

[Saurabh Anand [:sawrubh]]

Even when one is signed into Sync, when we open the Customize menu, it shows 'Sign in to Sync' while I think it should instead show the email address or someway to indicate that we're already signed into Sync. It's a wrong indicator for the current state, I guess.

Comment 1

[:Gijs (he/him)]

Mark, can you look into this?

Saurabh, can you provide more precise STR? Does this only happen if you open customize immediately after opening, or all the time, or...?

Comment 2

[Saurabh Anand [:sawrubh]]

This happens all the time, on all the platforms (at least Windows and Linux, which I use).

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I've never heard of this and can't imagine what might cause it.  But:

* Can you confirm you are using a "Firefox Account" or an older "legacy" account?  You should be able to tell from the sync prefs pane.  (Either way, the described behaviour is wrong, but it would help to know what direction the problem lies).

* Can you try in safe mode?  There's an off-chance it is an addon.

* Can you open the error console after you see the problem and look for any errors?  If you like, just add the entire contents of that console as an attachment and I'll look for anomalies.

Comment 4

[Saurabh Anand [:sawrubh]]

Attachment: Screenshot of the Customize UI with the issue

a) Yes, I'm using a Firefox Account.
b) Yes, this happens even in Safe Mode for me.
c) I'm not really sure what's meant by the Error Console. If you mean the Console in the DevTools, i) I'm not really sure how it log errors related to the Customize UI page since it's an internal browser page ii) The Customize UI page anyway opens in a new tab and then closes, leaving no option to see the logged errors before and after the activity of opening the Customize UI.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

(In reply to Saurabh Anand [:sawrubh] from comment #4)
> The Customize UI page anyway

doh - I totally missed that this was about the "Customize UI" even though they are the first words of the bug description :/

So, yeah, same for me.

Comment 6

[Mark Hammond [:markh] [:mhammond]]

FWIW, note that the behaviour of the button is explicitly done this way (in browser-fxaccounts.js) - it's not clear why and it's probably easy to fix.

Comment 7

[Drew Willcoxon :adw]

It looks there's no reason other than that Gijs said, "You might also want to reset the label to something more generic than the actual sign in state here," and then Tim said, "Good idea."  From bug 957460 comment 17 and 18.  _inCustomizationMode was introduced in the patch in comment 18.

Comment 8

[:Gijs (he/him)]

(In reply to Drew Willcoxon :adw from comment #7)
> It looks there's no reason other than that Gijs said, "You might also want
> to reset the label to something more generic than the actual sign in state
> here," and then Tim said, "Good idea."  From bug 957460 comment 17 and 18. 
> _inCustomizationMode was introduced in the patch in comment 18.

Yeah, this should have a third label (besides "Sign in" and "Signed in as <email>") to indicate what it is in customize mode, not reuse the "Sign in" label. Sorry for not making that clear.

Comment 9

[Mark Hammond [:markh] [:mhammond]]

(In reply to Gijs Kruitbosch from comment #8)
> Yeah, this should have a third label (besides "Sign in" and "Signed in as
> <email>") to indicate what it is in customize mode, not reuse the "Sign in"
> label. Sorry for not making that clear.

I guess I don't really understand why we don't have the text as shown when not in customize mode.  It would seem to be clearer to the user that the element looks exactly the same in customize mode, so there's less cognitive dissonance when switching modes.  The only downside is that in customize mode, clicking the element doesn't do what it says it does, but that's true for all buttons in customize mode.

But yeah, this is why I'm not in the UX team ;)

Comment 10

[Mark Hammond [:markh] [:mhammond]]

Bug 1214801 has UX input, so I'm marking this as a dupe of that (even though it would normally be the other way around!)