111213 - JS doesn't restart when SetScriptsEnabled is called with true

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[rods (gone)]

Filing this as a dependency for my PrintPreview JS issue

Comment 1

[Phil Schwartau]

DOM is the component for this, not JS Engine. Reassigning. 

Comment 2

[rods (gone)]

Attachment: patch file

This should be checked in when jst's patch is chceked in.

Comment 3

[Johnny Stenback (:jst)]

Attachment: "Restart" JS when scripts are enabled on a context.

Comment 4

[Johnny Stenback (:jst)]

jband, sr=?

Comment 5

[John Bandhauer]

Comment on attachment 59289 [details] [diff] [review]
"Restart" JS when scripts are enabled on a context.

Why is this not called SetScriptsEnabled? ScriptsEnabled sounds like it is more
likely to Get than to Set. otherwise sr=jband

Comment 6

[Johnny Stenback (:jst)]

Good point, consider it renamed to SetScriptsEnabled().

Comment 7

[John Keiser (jkeiser)]

Comment on attachment 59289 [details] [diff] [review]
"Restart" JS when scripts are enabled on a context.

r=jkeiser

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 59202 [details] [diff] [review]
patch file

>+      if (nsnull != owner) {

>+        if (NS_SUCCEEDED(rv) && (nsnull != global)) {

>+          if (nsnull != domdoc) {

r=peterv but please change the |if (nsnull != foo)| to |if (foo)|.

Comment 9

[Johnny Stenback (:jst)]

Both patches checked in. Fixed.