Telemetry for tracking protection shield

RESOLVED FIXED in Firefox 37

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

35 Branch
Firefox 37
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Histograms already exist for measuring tracking protection events in desktop, we should just add the probes in the right place for Fennec.

  "TRACKING_PROTECTION_ENABLED": {
    "expires_in_version": "never",
    "kind": "boolean",
    "description": "Whether or not a session has tracking protection enabled"
  },
  "TRACKING_PROTECTION_SHIELD": {
    "expires_in_version": "never",
    "kind": "enumerated",
    "n_values": 4,
    "description": "Tracking protection shield (0 = not shown, 1 = blocked, 2 = loaded, 3 = due to mixed content"
  },
  "TRACKING_PROTECTION_EVENTS": {
    "expires_in_version": "never",
    "kind": "enumerated",
    "n_values": 3,
    "description": "Doorhanger shown = 0, Disable = 1, Enable = 2"
  },
(Assignee)

Comment 1

4 years ago
(In reply to :Margaret Leibovic from comment #0)
> Histograms already exist for measuring tracking protection events in
> desktop, we should just add the probes in the right place for Fennec.
> 
>   "TRACKING_PROTECTION_ENABLED": {
>     "expires_in_version": "never",
>     "kind": "boolean",
>     "description": "Whether or not a session has tracking protection enabled"
>   },

This is slightly redundant with our settings telemetry to tell us when users have enabled this. However, this would be useful for giving us an overview of what percentage of users actually have this enabled, so I think we should add it.

>   "TRACKING_PROTECTION_SHIELD": {
>     "expires_in_version": "never",
>     "kind": "enumerated",
>     "n_values": 4,
>     "description": "Tracking protection shield (0 = not shown, 1 = blocked,
> 2 = loaded, 3 = due to mixed content"
>   },

Our logic is different from desktop here in that we keep the tracking/mixed modes separate until our final decision about what icon to show in the urlbar, so I'm not sure whether we need to record the "due to mixed content" case. If we do, I think we would need to alter our logic to be able to actually record this information.

>   "TRACKING_PROTECTION_EVENTS": {
>     "expires_in_version": "never",
>     "kind": "enumerated",
>     "n_values": 3,
>     "description": "Doorhanger shown = 0, Disable = 1, Enable = 2"
>   },

We already do this, no changes needed.
(Assignee)

Comment 2

4 years ago
Created attachment 8538191 [details]
MozReview Request: bz://1112189/margaret
Attachment #8538191 - Flags: review?(mark.finkle)
(Assignee)

Comment 3

4 years ago
/r/1571 - Bug 1112189 - Additional telemetry for tracking protection shield. r=mfinkle

Pull down this commit:

hg pull review -r b0390757dbeacf4560f8e21d6c781f034f554bad
Attachment #8538191 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/75e9894b3028
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
(Assignee)

Comment 7

3 years ago
Comment on attachment 8538191 [details]
MozReview Request: bz://1112189/margaret
Attachment #8538191 - Attachment is obsolete: true
Attachment #8618929 - Flags: review+
(Assignee)

Comment 8

3 years ago
Created attachment 8618929 [details]
MozReview Request: Bug 1112189 - Additional telemetry for tracking protection shield. r=mfinkle
You need to log in before you can comment on or make changes to this bug.