1112230 - Find in page: Case insensitivity toolbar button no reacting to every touch event/tapping

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox for Android Nightly 2014-12-16

The icon to disable case sensitivity in the "Find in page" toolbar doesn't react to every touch event, only some. So I have to tap it sometimes 4-6 times until the state toggles.

Comment 1

[Wesley Johnston (:wesj)]

Hey mark, can you look at this?

Comment 2

[Mark Capella [:capella]]

Attachment: bug1112230.diff

The responsive area for the CheckedTextView is the actual text chars 'Aa' ... tapping somewhat near isn't good enough to trigger action ...

Expanding the internal padding widens the hit box ... pushing to try for archaeopteryx to check ...

https://tbpl.mozilla.org/?tree=Try&rev=d320d70c5fca

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8539399 [details] [diff] [review]
bug1112230.diff

Review of attachment 8539399 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you. After installing the opt build on a Nexus S with Android 4.1.2 stock image, the toggling of the case insensitivity works without issues. The phone rebooted when I loaded a page, but this should be unrelated to this patch and I couldn't reproduce the issue.

Comment 4

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/48b7608267e9

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/48b7608267e9