1112325 - Periodic update last synced value in the Remote Tabs home panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Over in Bug 1096669, vivek made the Firefox Account status screen update every minute, so that the "last synced" timestamp reflected when we did in fact sync last.  This ticket tracks doing the same for the Remote Tabs home panel.

Notes:

1) this is not forcing a sync, it's just updating the UI to reflect the current value;

2) we need to take care that we only update the UI when it's visible.

Comment 1

[Manu Jain]

I would like to patch this bug. Can you provide with some mxr/dxr links?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Manu Jain from comment #1)
> I would like to patch this bug. Can you provide with some mxr/dxr links?

Yes!  The relevant Home Panel is at [1].  I realize now that I haven't landed the work from the earlier bug yet (Christmas holiday has delayed things), but you can look at [2] for how vivek did the first version of this work.  It's a scheduled Runnable that updates the UI; you'll need to do similar.

[1] http://dxr.mozilla.org/mozilla-central/source/mobile/android/base/home/RemoteTabsExpandableListFragment.java

[2] https://bugzilla.mozilla.org/attachment.cgi?id=8534677

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1112325/nalexander

/r/6627 - Bug 1112325 - Update 'Last synced:' timestamp in Remote Tabs home panel every minute. r=vivek

Pull down this commit:

hg pull -r 44eefeacecbead3ead95ff8a961637eb097388df https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8588158 [details]
MozReview Request: bz://1112325/nalexander

/r/6627 - Bug 1112325 - Update 'Last synced:' timestamp in Remote Tabs home panel every minute. r=vivek

Pull down this commit:

hg pull -r 44eefeacecbead3ead95ff8a961637eb097388df https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8588158 [details]
MozReview Request: bz://1112325/nalexander

vivek: hey, do you want the review for this?  Can you see the RB link (it may be private)?

It's copy-paste of your code from Bug 1096669 and tweaks for the Home Panel.

Comment 6

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8588158 [details]
MozReview Request: bz://1112325/nalexander

looks good to me

Comment 7

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/fe2de1b97d73

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe2de1b97d73

Comment 10

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1112325 - Update 'Last synced:' timestamp in Remote Tabs home panel every minute. r=vivek