1112378 - Errors in WebAudio should propagate to exposed API, not thrown inside actors

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When doing web audio stuff that is invalid, instead of getting an error in my source code, I get an error from the call-watcher:

TypeError: Argument 1 is not valid for any of the 2-argument overloads of AudioNode.connect. call-watcher.js:421:37

We should somehow throw this from the content's origin, instead of obfuscated in dev tools source.

Possibly same issues with other tools that use call watcher.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Can't recreate in normal usage again, was doing some weird websocket stuff, will try to have a recreation case later.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Can recreate this by passing any invalid argument into an automation method.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1112378-callwatcher-errors.patch

Well this was a brutal one.

This works in all scenarios for errors and DOMExceptions, and shows the error as being on the correct content file/line.

The only scenario that isn't covered is when rendering a DOMException (errors are fine) directly as a string in the webconsole, as it still uses the call-watcher filename. Suspect that this is because we are not modifying the privileged DOMException, and just the content-version. Either way, this is better than what we had before, and the "error" lines thrown in content are all correct -- just when someone renders a DOMException in the console (like, catch the error and console.log it). I think this scenario is pretty small, and fine, and again, better than the error line showing up as originating from call-watcher.js.

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=1db13b6ade3a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/840ddbf2de5e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/840ddbf2de5e