Closed Bug 1112378 Opened 5 years ago Closed 5 years ago

Errors in WebAudio should propagate to exposed API, not thrown inside actors

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

37 Branch
x86
macOS
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

When doing web audio stuff that is invalid, instead of getting an error in my source code, I get an error from the call-watcher:

TypeError: Argument 1 is not valid for any of the 2-argument overloads of AudioNode.connect. call-watcher.js:421:37

We should somehow throw this from the content's origin, instead of obfuscated in dev tools source.

Possibly same issues with other tools that use call watcher.
Can't recreate in normal usage again, was doing some weird websocket stuff, will try to have a recreation case later.
Can recreate this by passing any invalid argument into an automation method.
Well this was a brutal one.

This works in all scenarios for errors and DOMExceptions, and shows the error as being on the correct content file/line.

The only scenario that isn't covered is when rendering a DOMException (errors are fine) directly as a string in the webconsole, as it still uses the call-watcher filename. Suspect that this is because we are not modifying the privileged DOMException, and just the content-version. Either way, this is better than what we had before, and the "error" lines thrown in content are all correct -- just when someone renders a DOMException in the console (like, catch the error and console.log it). I think this scenario is pretty small, and fine, and again, better than the error line showing up as originating from call-watcher.js.

 https://treeherder.mozilla.org/#/jobs?repo=try&revision=1db13b6ade3a
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8564463 - Flags: review?(vporof)
Attachment #8564463 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/840ddbf2de5e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.