1112435 - Breakpoint in pretty printed source not hit on reload

Status: RESOLVED INVALID

(DevTools :: Debugger, defect)

Description

[Nazar Mokrynskyi]

If "Automatically Black Box Minified Sources" is used - whenever you un-Black Box some file - breakpoints will not work in it anyway. Any kind of breakpoints - added manually, conditional, "debugger" in source code.

Comment 1

[Eddy Bruel [:ejpbruel]]

Are you saying debugger statements don't work either? That's interesting, because those use a very different mechanism internally than breakpoints.

Comment 2

[Nazar Mokrynskyi]

Exactly. Moreover, sometimes only debugger statements work, not breakpoints, but I do not know how to reproduce this, and this is another situation (I'm not blackboxing anything anymore).

Comment 3

[Hallvord R. M. Steen [:hallvors]]

I just had this problem while trying to debug event issues in bug 1138335.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Any test case w/ steps to reproduce for this? That would go a long way towards helping get this fixed.

Comment 5

[Hallvord R. M. Steen [:hallvors]]

1. load jquery.com
2. unblackbox jquery.min.js and reformat
3. set breakpoint on "return new m.fn.init(a, b)" line (line 23 in our reformatted source)
4. reload

Script is not shown greyed out (seems un-blackboxed), breakpoints are listed and shown as enabled - but it doesn't actually *stop* on them :-/

Comment 6

[Hallvord R. M. Steen [:hallvors]]

Is that all you need? Can you reproduce? :)

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks. I can repro now, but I'm not sure if this is an issue with the prettifier and/or source maps and breakpoints or black boxing.

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Interesting.

If I use a different source, black box that source, un black box that source, and then try to hit a breakpoint, then it succeeds.

If I turn off auto-black-boxing, and do the STR from comment 5 (sans un black boxing, obviously), then the breakpoint also succeeds.

Comment 9

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Ah, no wait. I can always make the breakpoint hit via `$("a")` in the console. This is an issue with breakpoints and pretty printed sources on reload. Most likely a race condition between the pretty printing finishing in a worker and the refresh + breakpoint being hit or something.

Comment 10

[Jason Laster [:jlast]]

I'm closing this bug as it does not pertain to the new UI.

The new UI does pretty printing on the client, which allows the server to only keep generated locations.

Comment 11

[1ac7b2edaa08e4edd3334c5dc4b966af]

Using formatted code for breakpoints is still fully broken for me. FF 53.0.3 Win7 32bit. Always. Reproducible.