1112446 - Add logging for media queue lengths

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matt Woodrow (:mattwoodrow)]

We want to be able to easily determine how many frames are in the queue (both MediaDecoderStateMachines one, and any frames cached by the reader/decoded).

This will make it easier to determine how much memory we are using, and how close we are to hitting starvation and stalling.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Log media queue length

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8537602 [details] [diff] [review]
Log media queue length

Review of attachment 8537602 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/fmp4/MP4Reader.cpp
@@ +664,5 @@
> +{
> +  auto& decoder = GetDecoderData(aTrack);
> +  MonitorAutoLock lock(decoder.mMonitor);
> +  /// XXX: For some PDM's we could also
> +  // count the frames in the reorder queue.

Suggestion: We should be able to do this by counting samples sent vs frames received. I think it is useful information.

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0683ba539dc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b0683ba539dc

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8537602 [details] [diff] [review]
Log media queue length

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This just adds logging code.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a3b3c0c0990