Add logging for media queue lengths

RESOLVED FIXED in Firefox 36

Status

()

Core
Audio/Video
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

(Blocks: 1 bug)

29 Branch
mozilla37
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We want to be able to easily determine how many frames are in the queue (both MediaDecoderStateMachines one, and any frames cached by the reader/decoded).

This will make it easier to determine how much memory we are using, and how close we are to hitting starvation and stalling.
(Assignee)

Comment 1

4 years ago
Created attachment 8537602 [details] [diff] [review]
Log media queue length
Attachment #8537602 - Flags: review?(ajones)
Comment on attachment 8537602 [details] [diff] [review]
Log media queue length

Review of attachment 8537602 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/fmp4/MP4Reader.cpp
@@ +664,5 @@
> +{
> +  auto& decoder = GetDecoderData(aTrack);
> +  MonitorAutoLock lock(decoder.mMonitor);
> +  /// XXX: For some PDM's we could also
> +  // count the frames in the reorder queue.

Suggestion: We should be able to do this by counting samples sent vs frames received. I think it is useful information.
Attachment #8537602 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/b0683ba539dc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment on attachment 8537602 [details] [diff] [review]
Log media queue length

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing, sites more likely to serve Flash video.
[Describe test coverage new/current, TBPL]: landed on m-c.
[Risks and why]: Low. This just adds logging code.
[String/UUID change made/needed]: None.
Attachment #8537602 - Flags: approval-mozilla-aurora?
status-firefox36: --- → affected
status-firefox37: --- → fixed
Attachment #8537602 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.