Closed
Bug 1112446
Opened 9 years ago
Closed 9 years ago
Add logging for media queue lengths
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
9.07 KB,
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We want to be able to easily determine how many frames are in the queue (both MediaDecoderStateMachines one, and any frames cached by the reader/decoded). This will make it easier to determine how much memory we are using, and how close we are to hitting starvation and stalling.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8537602 -
Flags: review?(ajones)
Comment on attachment 8537602 [details] [diff] [review] Log media queue length Review of attachment 8537602 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/fmp4/MP4Reader.cpp @@ +664,5 @@ > +{ > + auto& decoder = GetDecoderData(aTrack); > + MonitorAutoLock lock(decoder.mMonitor); > + /// XXX: For some PDM's we could also > + // count the frames in the reorder queue. Suggestion: We should be able to do this by counting samples sent vs frames received. I think it is useful information.
Attachment #8537602 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0683ba539dc
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b0683ba539dc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Comment 5•9 years ago
|
||
Comment on attachment 8537602 [details] [diff] [review] Log media queue length Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Less consistent testing, sites more likely to serve Flash video. [Describe test coverage new/current, TBPL]: landed on m-c. [Risks and why]: Low. This just adds logging code. [String/UUID change made/needed]: None.
Attachment #8537602 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
Updated•9 years ago
|
Attachment #8537602 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•