Closed Bug 1112490 Opened 6 years ago Closed 6 years ago

Parallel build should output a make error when an error is thrown by app

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rickychien, Assigned: rickychien)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
gduan
: review+
Details | Review
No description provided.
Parallel build has been introduced a few weeks ago. However, when app throw an error in parallel processes, we should output a make error instead of "Finished ..." message or even stop building.
Summary: Parallel build should stop running when an error is thrown by app → Parallel build should output Makefile error when an error is thrown by app
Summary: Parallel build should output Makefile error when an error is thrown by app → Parallel build should output a make error when an error is thrown by app
Attached file Gaia PR
Attachment #8539052 - Flags: review?(gduan)
Comment on attachment 8539052 [details] [review]
Gaia PR

LGTM, r=gduan
Since it will fail the whole test if any failure is found when building after your commit, I suggest to push to try before landing.
Attachment #8539052 - Flags: review?(gduan) → review+
Try is green. Let's land it!

https://github.com/mozilla-b2g/gaia/commit/85c5d7d5f7cbf5d3261197d571a0e2215b51d4ee
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.