Closed
Bug 1112515
Opened 11 years ago
Closed 11 years ago
Add unit tests for the hawk authentication code
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amac, Assigned: amac)
References
Details
Attachments
(1 file)
Currently there are no unit tests for the hawk library (hawk.js). As a first step to replace it (currently we're using two different cryptographic libraries, and the current hawk.js code is a bit like the Frankenstein monster, only without biological parts).
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8537714 -
Flags: review?(josea.olivera)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8537714 [details] [review]
Unit tests for hawk.js
LGTM. r=me
Everything green!. Thanks for adding tests Antonio.
Attachment #8537714 -
Flags: review?(josea.olivera) → review+
|
|
||
Comment 3•11 years ago
|
||
Landed on master branch at:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/51a04dd1f06cba2f2de4f8bfb718e719c2b1361e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•