1112653 - Rename Account to Profile

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

I find it confusing having conversations about fx-accounts and our Account abstraction (which used to be a FxAccount, but isn't anymore). We should just rename our Accounts to Profiles to match Fennec and remove confusion.

Comment 1

[Richard Newman [:rnewman]]

I'll knock this out tonight.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Pull req.

WIP.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8538987 [details] [review]
Pull req.

This now passes tests. There's a little commented-out code, and I'm still thinking about the proper way to relate Profile and Account -- I don't think inheritance is really the right way to do it, but at least now we have a separate protocol, so this is a step in the right direction.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8538987 [details] [review]
Pull req.

Looks sane to me.

Comment 5

[Richard Newman [:rnewman]]

Gonna wait for a second opinion before I land this, 'cos it's a non-trivial change.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8538987 [details] [review]
Pull req.

Move fast, maybe break things.

https://github.com/mozilla/firefox-ios/commit/7ae37563d3c3aba8edc4e430c1429838c2e32cfb