I find it confusing having conversations about fx-accounts and our Account abstraction (which used to be a FxAccount, but isn't anymore). We should just rename our Accounts to Profiles to match Fennec and remove confusion.
I'll knock this out tonight.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
OS: Mac OS X → iOS 7
Hardware: x86 → All
Comment on attachment 8538987 [details] [review] Pull req. This now passes tests. There's a little commented-out code, and I'm still thinking about the proper way to relate Profile and Account -- I don't think inheritance is really the right way to do it, but at least now we have a separate protocol, so this is a step in the right direction.
Comment on attachment 8538987 [details] [review] Pull req. Looks sane to me.
Attachment #8538987 - Flags: feedback?(bnicholson) → feedback+
Gonna wait for a second opinion before I land this, 'cos it's a non-trivial change.
Comment on attachment 8538987 [details] [review] Pull req. Move fast, maybe break things. https://github.com/mozilla/firefox-ios/commit/7ae37563d3c3aba8edc4e430c1429838c2e32cfb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.