Rename Account to Profile

RESOLVED FIXED

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wesj, Assigned: rnewman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
bnicholson
: feedback+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
I find it confusing having conversations about fx-accounts and our Account abstraction (which used to be a FxAccount, but isn't anymore). We should just rename our Accounts to Profiles to match Fennec and remove confusion.
(Assignee)

Comment 1

4 years ago
I'll knock this out tonight.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
OS: Mac OS X → iOS 7
Hardware: x86 → All
(Assignee)

Comment 2

4 years ago
Created attachment 8538987 [details] [review]
Pull req.

WIP.
(Assignee)

Comment 3

4 years ago
Comment on attachment 8538987 [details] [review]
Pull req.

This now passes tests. There's a little commented-out code, and I'm still thinking about the proper way to relate Profile and Account -- I don't think inheritance is really the right way to do it, but at least now we have a separate protocol, so this is a step in the right direction.
Attachment #8538987 - Flags: feedback?(sarentz)
Attachment #8538987 - Flags: feedback?(bnicholson)
Comment on attachment 8538987 [details] [review]
Pull req.

Looks sane to me.
Attachment #8538987 - Flags: feedback?(bnicholson) → feedback+
(Assignee)

Comment 5

4 years ago
Gonna wait for a second opinion before I land this, 'cos it's a non-trivial change.
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.