Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
According to bug 1104198 comment 21, we no longer need to support SIMULATOR=1.
Created attachment 8538052 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support to mozilla-b2g:master
(Assignee)

Comment 2

4 years ago
Comment on attachment 8538052 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support to mozilla-b2g:master

Alex - this is just a huge code deletion to remove DESKTOP and SIMULATOR flags, it should help us clean up the tree a bit. Mind giving it a review? Thanks!
Attachment #8538052 - Flags: review?(poirot.alex)
Comment on attachment 8538052 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support to mozilla-b2g:master

Looks good to me, but I would keep additional-extensions rule for now.

Otherwise, be careful, there is still a failure on gaia build tests.
Attachment #8538052 - Flags: review?(poirot.alex) → review+
I think everyone stopped working on Fx nightly and also stopped using DESKTOP mock helpers.
But may be that's something we should announce on the ML?
I don't know, I think you have a better picture of gaia developers habits.
(Assignee)

Comment 5

4 years ago
Eitan - Quick question, do you guys still plan on using the "additional extensions" functionality? Since desktop is broken, and will probably not be fixed anytime soon, I think we should remove the shim support from it for now, and push forward with the new simulator.

Just wanted to check with you if we should keep the additional extensions functionality. Thanks!
Flags: needinfo?(eitan)
(In reply to Kevin Grandon :kgrandon from comment #5)
> Just wanted to check with you if we should keep the additional extensions
> functionality. Thanks!

My main motivation for getting this cleaned up was so that the additional extensions would work well with the mulet setup, and the screen reader simulator would interoperate.

Unless I am missing something, we really want two flags:
DEBUG: installs the httpd extension and allows running gaia through the app directories without having to do 'make' between runs.
DESKTOP: installs additional extensions.
Flags: needinfo?(eitan)
(Assignee)

Comment 7

4 years ago
Ok, thanks guys. I think I am going to simplify this into a few patches then to make sure I don't break anything. I think I'll start by pulling out simulator support, then removing the shimming extensions that we don't use any more.
Created attachment 8540326 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support_2 to mozilla-b2g:master
(Assignee)

Comment 9

4 years ago
Comment on attachment 8540326 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support_2 to mozilla-b2g:master

This is a new PR which only removes simulator support for now. Carrying R+ as it's only a subset of the previous patch.
Attachment #8540326 - Flags: review+
(Assignee)

Comment 10

4 years ago
Comment on attachment 8538052 [details] [review]
[PullReq] KevinGrandon:bug_1112745_remove_desktop_support to mozilla-b2g:master

Obsoleting in favor of smaller patches and not breaking additional extensions.
Attachment #8538052 - Attachment is obsolete: true
(Assignee)

Comment 11

4 years ago
Let's just remove simulator support for now, and we can track removing the other extensions in another bug.
Keywords: checkin-needed
Summary: Remove simulator, desktop support → Remove simulator support
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 13

4 years ago
Oh right - because I created a new PR, funny :) Might need to fix the autoland process for that.

https://github.com/mozilla-b2g/gaia/commit/19c4ae5e90cc712f0ea791c535beb184fd9dd4a1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.